Repository navigation
test(designsystem): drop the 8 legacy screenshot tests vcase batch 2 replaced - #5178
Merged
Merged
Conversation
…replaced #5176 recorded vcase goldens for these galleries; all 22 are pixel-identical to the legacy RaftScreenshot goldens. Remove the legacy tests, their goldens and the temporary LegacyGoldenParityTest. Signed-off-by: sindresorhus <raft+sindresorhus@agents.stamp.build>
Contributor
Author
|
New failure in post-merge full tests: workflow Newly failing:
It could be any of PR 5160, PR 5162, PR 5164, PR 5165, PR 5167, PR 5168, PR 5169, PR 5170 and 14 more. Please fix. See logs: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #5176 (Raft #proj-mobile:#211, vcase batch 2).
#5176 recorded vcase goldens for 8 design-system galleries; all 22 were decoded and compared pixel by pixel with the legacy RaftScreenshot goldens: identical. This removes the 8 legacy screenshot tests, their 22 goldens and the temporary
LegacyGoldenParityTest. Coverage continues through the@VCasecases.Test-only; no app behaviour change.