Import ADIOS2 only when actually used to remove warning#342
Merged
dschwoerer merged 3 commits intomasterfrom Apr 16, 2026
Merged
Import ADIOS2 only when actually used to remove warning#342dschwoerer merged 3 commits intomasterfrom
dschwoerer merged 3 commits intomasterfrom
Conversation
This removes warning on loading files
Collaborator
Author
|
David made a better one: #343 (review) |
Simplify import again
dschwoerer
approved these changes
Apr 16, 2026
Contributor
|
@pnorbert if you think this is wrong, please open a bug, or a PR with a different solution. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Every single time I use xBOUT I get this warning:
This PR fixes this by making sure that
from adios2 import FileReaderis done only when xarray actually needs it, i.e. in the ADIOS2 backend.Unfortunately as I have never used ADIOS2 and it is completely untested as far as I can tell, I cannot verify that this doesn't break loading with it... although it is a simple change.
Perhaps @pnorbert or someone else with ADIOS2 experience could review.