Open
Conversation
The path check assumed the path was a string, which would make the dataset load in a non-lazy way if the path was pathlib.Path
Collaborator
Author
|
Looks like we have another CI failure mystery.... |
ZedThree
reviewed
Apr 20, 2026
Comment on lines
+354
to
+355
| if name == "dz": | ||
| data_vars[name] = var |
Member
There was a problem hiding this comment.
The logs show the tests failing due to missing dz -- this is the only change that mentions dz, but I don't see how it could fail (this line doesn't seem to come up in the stacktrace either)
Contributor
There was a problem hiding this comment.
This is what I added to fix it :-)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The new lazy loader assumed that all paths are strings. When passed a
pathlib.Path, it would fall back to the non-lazy loader. This caused me quite a bit of confusion as some of my simulations started taking forever to load.There is already a tool called
_is_path. This PR makes the lazy loader use this to check, which makes it consistent with the same operation elsewhere in the code.@bendudson was the intention to still lazy load even for a single file? The code design suggests not (you are checking for a
collectionof files), but in practice single files will still get lazy loaded in the current implementation.