feat: initial implementation for caps lock warning - #154
Draft
kerembayulgen wants to merge 1 commit into
Draft
Conversation
Simple prototype for a caps lock warning. Currently does not show while typing.
Owner
|
Hi, and thanks for the pull request! I have some thoughts on how the design of this should work:
This is cleaner and more useful design wise, but complicates the code part a bit. I suggest creating a new function in
If you have any questions, let me know. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Simple caps lock warning
It does not show currently up while typing as I thought that the user would be acknowledging it before starting to type and it would be a distraction
Also, I think that the warning should be in bold text, but I haven't seen any GNOME apps use anything besides the "warning" style class.