fix(google_genai): include thinking tokens in completion usage - #619
Closed
ekeith (evanmkeith) wants to merge 2 commits into
Closed
fix(google_genai): include thinking tokens in completion usage#619ekeith (evanmkeith) wants to merge 2 commits into
ekeith (evanmkeith) wants to merge 2 commits into
Conversation
## Summary - Fold Gemini `thoughts_token_count` into Google GenAI `completion_tokens` - Preserve `completion_reasoning_tokens` as the separate reasoning detail metric - Tighten the reasoning regression test to assert span metrics match provider usage metadata ## Testing - `nox -s "test_google_genai(latest)" -- -k test_reasoning` - `nox -s "test_google_genai(latest)"` - `nox -s "test_google_genai(1.75.0)" -- -k test_reasoning` - `nox -s "test_google_genai(1.30.0)" -- -k test_reasoning` - `git diff --check`
ekeith (evanmkeith)
changed the title
Member
|
This needs a more robust fix, so closing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
thoughts_token_countinto Google GenAIcompletion_tokenscompletion_reasoning_tokensas the separate reasoning detail metricTesting
nox -s "test_google_genai(latest)" -- -k test_reasoningnox -s "test_google_genai(latest)"nox -s "test_google_genai(1.75.0)" -- -k test_reasoningnox -s "test_google_genai(1.30.0)" -- -k test_reasoninggit diff --checkRelated to https://linear.app/braintrustdata/issue/SDK-99