Update google provider types#348
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b6b114edb6
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "Codex (@codex) review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "Codex (@codex) address that feedback".
| #[serde(rename = "NONE")] | ||
| ModeNone, |
There was a problem hiding this comment.
None variant or update callers
Renaming this variant to ModeNone leaves the Google converter and tests still matching/constructing FunctionCallingConfigMode::None in crates/lingua/src/providers/google/convert.rs, including the tool-choice-none path. Since the google feature is enabled by default, those references no longer resolve and the crate will not compile until the callers are updated or the generated variant name remains None.
Useful? React with 👍 / 👎.
| #[serde(rename = "STRING")] | ||
| TypeString, |
There was a problem hiding this comment.
string schema types
This replacement drops the previous #[serde(alias = "string")], so deserializing a Google Schema from standard JSON Schema with {"type":"string"} now fails only for string fields while the other lowercase types still work. The generator explicitly adds these aliases so typed Google schemas can accept both Google uppercase values and OpenAI/JSON-Schema lowercase values; add the alias back alongside the STRING rename.
Useful? React with 👍 / 👎.
1 participant
Automated update of Lingua provider types.
Provider:
googleFeedback: comment
/bt goodor/bt badto log review feedback to the Braintrust trace.Validation
./pipelines/generate-provider-types.sh google: failure./pipelines/generate-provider-types.sh google: failuremake generate-types: failuremake generate-types: failurecargo fmt --all: successcargo build --all-features: failurecargo clippy --all-targets --all-features -- -D warnings: failuremake typed-boundary-check: successcargo test -p coverage-report --test cross_provider_test cross_provider_transformations_have_no_unexpected_failures: failureThis PR is created even when validation fails so the generated update and repair attempt are available for manual follow-up.