Repository navigation
fix(holidays,bank-account): add Rio de Janeiro's Corpus Christi and accept 12 digit Caixa accounts - #598
Merged
hyanmandian merged 10 commits intoSep 29, 2026
Conversation
…ccept 12 digit Caixa accounts Lei RJ nº 11.002/2025 made Corpus Christi (Easter plus 60) a feriado estadual in force on its publication, and the STF upheld it in ADI 7898 (trânsito em julgado 13/08/2026), so with stateCode "RJ" it is typed "state" from 2026 on, as in the Distrito Federal and Maranhão. Goiás' 28/10/2026, moved to 30/10 by Decreto GO nº 10.987/2026, joins the one-off decree dates the table documents without carrying. The Caixa layouts (CNAB 400 notes NE051 and NE052, CNAB 240 note G011) describe the account with 12 digits, "sem operação", and publish both of its check digits with worked examples. isValidBankAccount only took the older 11 digit operação + conta form, so every 12 digit Caixa account was rejected; it now takes either digit over a 12 digit account, and keeps the compendium rule for 11 digits. The Santander account digit and the Banco do Brasil agency digit, also published in each bank's manuals, match the rules already here, and all three manuals are now cited. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01RLkm9YrtAifc6XCLFVEsdH
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
commit: |
Contributor
Tree-shaking report✅ No size regression. 7 grew out of 187 exports.
What changed (7)
All exports (187)
How this is measuredEvery export is imported alone into an esbuild consumer bundle (minified, tree-shaken) built from the head and from the base of this pull request; the sizes are the resulting bundles, gzip is their gzipped size. 🔴 marks a regression: a pre-existing export that grew more than 20% and more than 256 B, or the bundle importing every pre-existing export growing more than 5%. 🟡 is growth under the threshold, 🟢 a decrease, ⚪ no change, 🆕 an export that does not exist on the base (never a regression), 🗑️ an export that was removed. An intentional increase is accepted with the |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## claude/area-code-municipalities #598 +/- ##
=================================================================
Coverage 100.00% 100.00%
=================================================================
Files 227 227
Lines 2364 2367 +3
Branches 706 707 +1
=================================================================
+ Hits 2364 2367 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
7 tasks done
7 tasks done
hyanmandian
added this pull request to stack #614
September 29, 2026 04:08
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Stacks on #597. It applies what the second round of the official-source investigation found against the stack.
Holidays
stateCode: "RJ"it is now typed"state"from 2026 on, the same as DF and MA.includeOptional: falseit still counts as a non-business day.isValidBankAccount, Caixa (104)Official citations
@see Official, and the docs say which rules have an official source.Checklist
docs/utilities.mdanddocs/pt-br/utilities.md.npm run checkpasses locally. Coverage (7783 tests), Deno, Stryker onis-valid-bank-account.ts(100%) andcheck:apialso pass.npm run build:llms.check:apireports no breaking change against 2.4.0.Additional context
Sources: the Lei RJ nº 11.002/2025 text on the ALERJ site, STF ADI 7898, Decreto GO nº 10.987/2026, and the Caixa, Santander and Banco do Brasil layout manuals (links in the JSDoc).
🤖 Generated with Claude Code
https://claude.ai/code/session_01RLkm9YrtAifc6XCLFVEsdH
Generated by Claude Code