Skip to content

Manually enable neon for the vita#2791

Merged
briansmith merged 1 commit intobriansmith:mainfrom
vita-rust:v0.17-vita
Mar 10, 2026
Merged

Manually enable neon for the vita#2791
briansmith merged 1 commit intobriansmith:mainfrom
vita-rust:v0.17-vita

Conversation

@pheki
Copy link
Copy Markdown
Contributor

@pheki pheki commented Mar 10, 2026

Followup of #2749, thank you so much for the tip there!

I've based my changes on how it's done in src/cpu/aarch64/mod.rs.

cargo bench doesn't run directly on the vita, but hacking the bench a bit I see more than a 6x improvement on the iteration time for aead::seal_in_place_separate_tag.

One interesting note here is that cfg(target_feature="neon") does seem to work on current nightly (based on the output of rustc +nightly --print cfg --target=armv7-sony-vita-newlibeabihf) and as the vita is nightly only that would probably be enough, but it could have rustc version dependent behavior for other targets so it may not be the best idea.

@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 10, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.71%. Comparing base (767e8b4) to head (cd9ee98).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2791   +/-   ##
=======================================
  Coverage   96.71%   96.71%           
=======================================
  Files         204      204           
  Lines       20361    20361           
  Branches      519      519           
=======================================
  Hits        19692    19692           
  Misses        552      552           
  Partials      117      117           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@briansmith briansmith merged commit a8dc60e into briansmith:main Mar 10, 2026
160 of 161 checks passed
@briansmith
Copy link
Copy Markdown
Owner

Thanks! Great work!

@pheki pheki deleted the v0.17-vita branch March 11, 2026 03:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants