Manually enable neon for the vita#2791
Merged
briansmith merged 1 commit intobriansmith:mainfrom Mar 10, 2026
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2791 +/- ##
=======================================
Coverage 96.71% 96.71%
=======================================
Files 204 204
Lines 20361 20361
Branches 519 519
=======================================
Hits 19692 19692
Misses 552 552
Partials 117 117 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Owner
|
Thanks! Great work! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Followup of #2749, thank you so much for the tip there!
I've based my changes on how it's done in
src/cpu/aarch64/mod.rs.cargo benchdoesn't run directly on the vita, but hacking the bench a bit I see more than a 6x improvement on the iteration time foraead::seal_in_place_separate_tag.One interesting note here is that
cfg(target_feature="neon")does seem to work on current nightly (based on the output ofrustc +nightly --print cfg --target=armv7-sony-vita-newlibeabihf) and as the vita is nightly only that would probably be enough, but it could have rustc version dependent behavior for other targets so it may not be the best idea.