Added sqlserver compatibility including CI#248
Added sqlserver compatibility including CI#248jgilfillan wants to merge 2 commits intobrooklyn-data:mainfrom
Conversation
|
I've reviewed the linting errors and I can't figure out why the code is failing for most of the exceptions. For example, there's nothing obviously wrong with the two items in the attached pic. Any help would be appreciated. |
@NiallRees hoping you can provide some assistance - I'm at a loss trying to figure out why most of the linting failed. |
Hi @jgilfillan - don't worry about those. I'll try and review the PR this week! |
| DBT_CLOUD_RUN_REASON: "String with 'quotes' !" | ||
| TEST_ENV_VAR_1: TEST_VALUE | ||
| DBT_ENV_CUSTOM_ENV_FAVOURITE_DBT_PACKAGE: dbt_artifacts | ||
| # These are configured in GitHub secrets |
There was a problem hiding this comment.
Don't these need to be under the env key?
There was a problem hiding this comment.
Right you are, I've updated my branch with this change.
|
|
||
| exposures: | ||
| - name: "ceo's imaginary dashboard" | ||
| - name: "ceos_imaginary_dashboard" |
There was a problem hiding this comment.
What's the thinking here? :)
There was a problem hiding this comment.
dbt 1.3 gave a warning that spaces in the name will not be permitted in a future version. Also with sql server the spaces were failing the ci tests, so killed two birds with one stone.
|
@NiallRees is there anything else you're waiting on from me to accept this pr? |
|
Hi @jgilfillan thank you for contributing with this, and I'm really sorry that our response has been delayed. We are going to work through the issue backlog now, and get to reviewing this again as soon as possible. |
Any progress on approving this PR? |
@glsdown It would be good to get an indication if there are any plans to merge this code. The SQL Server compatibility was added on the advice from this project that it would be accepted. So if this has changed it would be good to communicate this so alternative plans can be made (for SQL Server, Synapse, Fabric). |
|
@glsdown can you please give us an update on this one? |
+1 @jgilfillan, Any plans to update the PR or anything @llifoawing brooklyn-data could help with? It's a shame that it has not been merged yet. |
|
@JustGitting the project maintainers have not responded to any messages in over 2 years. I doubt there is going to be any movement on this PR. I note the project readme states sql server is now supported, so perhaps this PR is no longer required? I am not needed to use this project any longer so have not stayed that close to its development. |
6 participants
this PR relatest to #194
Backlog:
Making sure the adapter you're supporting implements the type helpers used in the source models.Adding overwrites for the custom type helpers if requiredIf required, creating adapter-specific version of the upload_* macros.Adding SQLServer CI supportI do not have access to a snowflake, databricks or bigquery server so relying on the CI tests to confirm all is working.