fix: add null guard in getYahooIndiaSuggestions to prevent TypeError#723
Open
Cocoon-Break (kuishou68) wants to merge 1 commit intobrowseros-ai:devfrom
Open
Conversation
Contributor
|
PR author is not in the allowed authors list. |
Contributor
|
All contributors have signed the CLA. Thank you! |
Author
|
I have read the CLA Document and I hereby sign the CLA |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #722
Problem
In
getSearchSuggestions.ts, thegetYahooIndiaSuggestionsfunction accessesdata.gossip.resultswithout any null/undefined guard:If the Yahoo API returns an unexpected response shape (e.g.
data.gossipisnullorundefined), this throws an uncaughtTypeErrorthat can break the search suggestions UI entirely. Every other provider safely usesdata[1] || [], but Yahoo lacks this protection.Fix
Use optional chaining and nullish coalescing, consistent with how other providers handle missing data:
This ensures an empty array is safely returned when the API response is missing or malformed.