Warn when launcher wizard finds Live Channels Provider disabled#20
Merged
Conversation
After Setup-Launcher finishes its set-default flow, Test-ChannelDependencies checks whether com.android.providers.tv is in the disabled list. If so, the new launcher will appear with an empty Watch Next / Continue Watching row regardless of which streaming apps are installed — because the TvProvider is the system content provider every app uses to publish those entries. Surfaces a warning explaining the consequence and offers to re-enable the provider in place. Avoids the silent state Bryan hit in real life: provider disabled from a previous session, switch launcher, can't figure out why Apple TV's Continue Watching is empty. No effect on the launcher swap itself; runs only after the launcher has been set up successfully.
Review caught that placing Test-ChannelDependencies at the very end of Setup-Launcher only fires on the "default launcher set successfully" path. The already-active, stock-fallback, and various decline/abort paths all skipped it — even though the TvProvider dependency is just as relevant on those branches. Moved the call to immediately after the disabled-packages snapshot at the top of Setup-Launcher so every custom-launcher exit path benefits. Test-ChannelDependencies now accepts the already-fetched `pm list packages -d` blob via an optional -DisabledPackages parameter, avoiding a redundant ADB roundtrip.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After `Setup-Launcher` successfully sets the chosen launcher as default, `Test-ChannelDependencies` checks whether `com.android.providers.tv` is in the disabled package list. If so, it surfaces a warning explaining that the new launcher's Watch Next / Continue Watching row will be empty regardless of which streaming apps are installed — because the TvProvider is the system content provider every app uses to publish those entries — and offers to re-enable the provider in place.
Why
Real-device repro: `com.android.providers.tv` was disabled from a previous session. User switched to Projectivy, opened Apple TV, and couldn't figure out why Continue Watching was empty. The launcher wizard had no awareness of the dependency.
Verification
Pairs with #19 (description sharpening on the same package).