Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR handles some error cases. Some of them are deep exception catches. I'm not going to pretend I understand it all, as this was mostly done under the guidance of LLM.
The main thing, is that sometimes you get an an actual error (
Chamfer failed: OCCT: There are no suitable edges for chamfer or fillet) and sometimes it's just silly "something failed" (Chamfer failed: IsDone = false)This PR comes on top of PR #222
To demonstrate this:
before:
...repeated chamfers on the face after:
before this PR, if you try chamfering again on the middle square, it would just cause a sig-abort because a Standard_Failure exception would just run amok. This PR catches this exception (at least, in the case of chamfering), and gets it to cross the ffi as a rust error.
...happy days!