Class abstraction and provider script - #1
Open
shreyaspapi wants to merge 13 commits into
Open
Conversation
shreyaspapi
commented
Sep 6, 2022
shreyaspapi
commented
Contributor
- Provider
|
I am going to pull either tomorrow or day after and then merge / close this PR.. It's pretty late now and I have some work with Shil tomorrow.. Good work regardless though.. and great job incorporating the Singleton pattern.. This is a solid base! |
Contributor
Author
|
@thisispalash don't merge / close leave it as is I need this PR to test the CI /CD workflow. |
nikramakrishnan
left a comment
nikramakrishnan
left a comment
There was a problem hiding this comment.
Threading, handler, and listener implementation are partially done. Also need to add a README.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.