Discard ViewLoad spans and associated AppStartup spans if the ViewController's viewLoad is interrupted by the User moving on to another screen #548

robert-smartbear · 2025-12-11T21:05:49Z

Goal

Discard ViewLoad spans and associated AppStartup spans if the ViewController's viewLoad is interrupted by the User moving on to another screen

Changeset

instrumented viewWillDisappear

Testing

E2E tests

…_attributes_onSpanEnd_for_blocked_spans Fixed an issue where onSpanEnd callbacks would fail to set attributes of blocked spans

…d in reprocessing (#538) Co-authored-by: Robert Bartoszewski <[email protected]>

…justed (#541) Co-authored-by: Robert Bartoszewski <[email protected]>

…enever there is an ended and blocked span on the top of the stack (#540) Co-authored-by: Robert Bartoszewski <[email protected]>

Bumps [github/codeql-action](https://github.com/github/codeql-action) from 4.31.6 to 4.31.7. - [Release notes](https://github.com/github/codeql-action/releases) - [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md) - [Commits](github/codeql-action@fe4161a...cf1bb45) --- updated-dependencies: - dependency-name: github/codeql-action dependency-version: 4.31.7 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Bumps [actions/checkout](https://github.com/actions/checkout) from 6.0.0 to 6.0.1. - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@1af3b93...8e8c483) --- updated-dependencies: - dependency-name: actions/checkout dependency-version: 6.0.1 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

…een started on a background thread (#539) Co-authored-by: Robert Bartoszewski <[email protected]>

# Conflicts: # BugsnagPerformance.xcodeproj/project.pbxproj # Sources/BugsnagPerformance/Private/BugsnagPerformanceImpl.mm # Sources/BugsnagPerformance/Private/Instrumentation/NetworkInstrumentation.mm # Sources/BugsnagPerformance/Private/Instrumentation/ViewLoadInstrumentation.mm # Sources/BugsnagPerformance/Private/Tracer.mm # features/default/manual_spans.feature # features/default/network.feature

…buted to viewDataLoading phase

…t happened during first view viewDataLoading phase

…ng_flow_changes

… robert/plat-15335_app_start_type_loading

…t happened before BugsnagPerformance had been started

…arly

…troller's viewLoad is interrupted by the User moving on to another screen

github-actions · 2025-12-11T21:07:50Z

BugsnagPerformance.framework binary size increased by 19,648 bytes from 885,152 to 904,800

    FILE SIZE        VM SIZE    
 --------------  -------------- 
   +43% +13.1Ki   +43% +13.1Ki    [__TEXT]
  +1.0% +1.89Ki  +1.0% +1.89Ki    __TEXT,__text
  +0.7% +1.71Ki  +0.7% +1.71Ki    String Table
  +0.8% +1.45Ki  +0.8% +1.45Ki    Symbol Table
  +1.5%    +372  +1.5%    +372    __TEXT,__objc_methname
  +1.5%    +304  +1.5%    +304    __TEXT,__gcc_except_tab
  +0.7%    +280  +0.7%    +280    __DATA,__objc_const
  +1.1%    +224  +1.1%    +224    __TEXT,__objc_stubs
  +1.2%     +96  +1.2%     +96    __TEXT,__unwind_info
  +1.2%     +64  +1.2%     +64    __DATA,__objc_selrefs
  +0.4%     +48  +0.4%     +48    __DATA_CONST,__const
  +1.1%     +24  +1.1%     +24    Function Start Addresses
  +0.4%      +8  +0.4%      +8    Rebase Info
  +0.9%      +8  +0.9%      +8    __DATA,__objc_ivar
  -0.2%      -8  -0.2%      -8    Binding Info
  -0.4%     -48  -0.4%     -48    [__DATA_CONST]
  -2.4%    -352  -2.4%    -352    [__DATA]
  [ = ]       0 -20.4% -3.19Ki    [__LINKEDIT]
  +2.2% +19.2Ki  +1.8% +16.0Ki    TOTAL

Generated by 🚫 Danger

DariaKunoichi · 2025-12-12T14:16:52Z

...mance/Private/Instrumentation/ViewLoadInstrumentation/System/ViewLoadSwizzlingHandlerImpl.mm

    });
 }

+void instrumentViewDidDisppear(Class cls, ViewLoadSwizzlingCallbacks *callbacks) noexcept {


typo in method name

DariaKunoichi · 2025-12-12T14:19:25Z

...agPerformance/Private/Instrumentation/AppStartupInstrumentation/AppStartupInstrumentation.mm

+        span.parentId == appStartSpan.spanId &&
+        span.traceIdHi == appStartSpan.traceIdHi &&
+        span.traceIdLo == appStartSpan.traceIdLo) {
+        lifecycleHandler_->onFirstViewWillDisappear(state_);


the name "onFirstViewWillDissapear" - I don't understand the name - what's supposed to happen?

Made some changes to make the code clearer

…errupted_view_loads

robert-smartbear and others added 19 commits December 9, 2025 12:14

Merge pull request #537 from bugsnag/robert/plat-15319_enable_setting…

c90a506

…_attributes_onSpanEnd_for_blocked_spans Fixed an issue where onSpanEnd callbacks would fail to set attributes of blocked spans

Fixed an issue where early network span attributes wouldn't be update…

b84ab83

…d in reprocessing (#538) Co-authored-by: Robert Bartoszewski <[email protected]>

Fixed an issue preventing some preloaded ViewLoad spans from being ad…

1fc957a

…justed (#541) Co-authored-by: Robert Bartoszewski <[email protected]>

Fixed an issue where current context would not calculated properly wh…

39aabf4

…enever there is an ended and blocked span on the top of the stack (#540) Co-authored-by: Robert Bartoszewski <[email protected]>

Fixed an issue where spans weren't sent when BugsnagPerformance has b…

ac8d49d

…een started on a background thread (#539) Co-authored-by: Robert Bartoszewski <[email protected]>

Removed commented out code

97a8729

Fixed an issue causing viewLoad phase child spans being wrongly attri…

18684de

…buted to viewDataLoading phase

Fixed build error

a1e31d7

Fixed an issue where app start type change wouldn't be reflected if i…

db407e6

…t happened during first view viewDataLoading phase

Merge branch 'integration/v2' into robert/plat-15338_plat-15320_loadi…

9cd8d14

…ng_flow_changes

Merge branch 'robert/plat-15338_plat-15320_loading_flow_changes' into…

d00b468

… robert/plat-15335_app_start_type_loading

Fixed E2E tests

4a33825

Fixed an issue where app start type change wouldn't be reflected if i…

fcf5a5c

…t happened before BugsnagPerformance had been started

Merge branch 'integration/v2' into robert/plat-15334_app_start_type_e…

fc03025

…arly

Fixed an issue causing callbacks to not be called

b2e68e1

Discard ViewLoad spans and associated AppStartup spans if the ViewCon…

6241592

…troller's viewLoad is interrupted by the User moving on to another screen

robert-smartbear requested a review from DariaKunoichi as a code owner December 11, 2025 21:05

robert-smartbear self-assigned this Dec 11, 2025

DariaKunoichi reviewed Dec 12, 2025

View reviewed changes

Base automatically changed from robert/plat-15334_app_start_type_early to integration/v2 December 15, 2025 08:59

robert-smartbear and others added 2 commits December 15, 2025 10:00

Merge branch 'integration/v2' into robert/plat-PLAT-15331_discard_int…

499b06f

…errupted_view_loads

Changes requested in code review

25dd0fa

DariaKunoichi approved these changes Dec 15, 2025

View reviewed changes

Fixed E2E tests

c9fa813

robert-smartbear merged commit d95fd41 into integration/v2 Dec 15, 2025
26 checks passed

robert-smartbear deleted the robert/plat-PLAT-15331_discard_interrupted_view_loads branch December 15, 2025 15:26

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Discard ViewLoad spans and associated AppStartup spans if the ViewController's viewLoad is interrupted by the User moving on to another screen #548

Discard ViewLoad spans and associated AppStartup spans if the ViewController's viewLoad is interrupted by the User moving on to another screen #548

Uh oh!

robert-smartbear commented Dec 11, 2025

Uh oh!

github-actions bot commented Dec 11, 2025 •

edited

Loading

Uh oh!

DariaKunoichi Dec 12, 2025

Uh oh!

DariaKunoichi Dec 12, 2025

Uh oh!

robert-smartbear Dec 15, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Discard ViewLoad spans and associated AppStartup spans if the ViewController's viewLoad is interrupted by the User moving on to another screen #548

Discard ViewLoad spans and associated AppStartup spans if the ViewController's viewLoad is interrupted by the User moving on to another screen #548

Uh oh!

Conversation

robert-smartbear commented Dec 11, 2025

Goal

Changeset

Testing

Uh oh!

github-actions bot commented Dec 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

DariaKunoichi Dec 12, 2025

Choose a reason for hiding this comment

Uh oh!

DariaKunoichi Dec 12, 2025

Choose a reason for hiding this comment

Uh oh!

robert-smartbear Dec 15, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

github-actions bot commented Dec 11, 2025 •

edited

Loading