Fix arithmetic expression crash in project-install.sh#317
Fix arithmetic expression crash in project-install.sh#317Perlover wants to merge 2 commits intobuildermethods:mainfrom
Conversation
Script crashed with `set -e` due to post-increment returning exit code 1 when chain_depth was 0. Changed to pre-increment so expression always returns non-zero value.
Perlover
changed the title
|
Similar implementation to #312 |
Replace post-increment ((var++)) with pre-increment ((++var)) to prevent script termination when using set -e. In bash, ((expr)) returns exit code 1 when the expression evaluates to 0, which happens with post-increment when the variable is 0. This fix ensures all commands are installed correctly instead of only the first one.
|
I confirm that without @Perlover changes i wasn't able to run project-install.sh on my ubuntu 24.04.3. |
|
Please approve and release asap |
|
The lack of response from the upstream is one reason I hesitated to adopt this project. I mainly use BMAD because of the excellent support from the community and the framework's author. I appreciate the design of this project, but the unresponsiveness is a significant concern. If we adopt the framework, it can be problematic to operate without any feedback or responses to community proposals. |
Totally agree. I've been waiting 10+ days for my PR (#320) to get any response - not even a comment or acknowledgment. The irony is that Brian's project is designed to help developers ship faster, yet the project itself is stuck in limbo. Multiple PRs fixing real bugs (Windows compatibility, arithmetic crashes) are just I ended up having to maintain my own fork just to keep working. Today I discovered another issue: scripts lose their execute permissions when copied between NTFS/Linux filesystems, causing "Permission denied" If the maintainer doesn't have bandwidth to review PRs, maybe it's time to consider:
A framework with 3.7k stars and 647 forks deserves active maintenance. The community is here and willing to contribute - we just need someone to merge. |
5 participants
Fix arithmetic expression crash in project-install.sh
Script crashed with
set -edue to post-increment returning exit code 1when chain_depth was 0. Changed to pre-increment so expression always
returns non-zero value.
#311