Open
Conversation
Contributor
Author
|
@seanmcn It seems that everything is fine here, before the release of the 2.x version it is better to apply these changes.. But it’s better to check it first, can you please do this? :) |
seanmcn
reviewed
Apr 18, 2024
Collaborator
|
One thing that's a bit strange to me, and this is probably more to do with the 2.x.x branch than this PR is now if I run: I get: Do I need to pass this in manually now or? |
Contributor
Author
|
@seanmcn For some reason I can't reply to the thread. The error in php demo/demo1/demoScript.php occurs because the demo config has not been corrected, it just needs to be corrected and the necessary option added |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
Checklist before requesting a review