[WIP] @ResourceBacked property wrapper#307
Open
pcantrell wants to merge 28 commits intofile-cachefrom
Open
Conversation
Also mopped up some cache request cleanup issues
bf69d83 to
a42150c
Compare
2751763 to
63baa8e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A common idiom in Siesta projects is to have UI code point at some resource that can change, and whenever it changes, to:
The Siesta docs and the example project recommend doing this via
didSet:Swift 5.2’s property wrappers give us a better option. This PR adds a
@ResourceBackedproperty wrapper that lets any variable take its value from a Siesta resource.The example above becomes:
The
doodadsvariable now behaves as if it is a read-onlyDoodadarray; for example, we can do this:However, that array comes from a Siesta resource — and we can switch which resource on the fly:
Changing the resource in this way automatically:
loadIfNeeded().Future work on this feature
$doodads.error. This would give better error reporting to the user if the server returns well-formed but unexpected content. (If you ask for$doodads.resource?.latestError, you still get only underlying resource errors, since resources (at least in Siesta 1.0) have freely typed content.)loadIfNeeded