Repository navigation
fix: Land the testmon and graph-helper time-limit fixes that merged into a stale branch (#965, #966) - #978
Merged
Conversation
…recorded_on_a_base_worktree_selects_correctly_in_a_unit_worktree_at_another_path` deterministic (#965) The tests come first and fail until the implementation. The test builds a small uv project (`Tiny`), commits it, records pytest-testmon data on it through `refresh_base_data`, hands the data to a worktree at another path, breaks `calc.py` there and runs a… Done when `Tiny`'s parallel command holds `-n 2 --maxprocesses=2` on any host, every test listed below carries the loaded limit, the two tests that start no `uv run` keep the default budget, and the… Unit: fix-test-tests-profiles-test-python-uv-testmon-real-py-test-d-94da774b/1
…8/1: Hold the graph-pass helpers build, built, built_after_a_pair and piece_built to the loaded test time limit (#966) * test: Make `tests/graph/test_per_group_unstubbed.py::test_one_pair_titled_with_the_unit_and_prompts_naming_all_groups[profile without stubs]` deterministic The tests come first and fail until the implementation. The test builds the same three-group unit twice through the unit graph: once stubbed (a pair of commits per group, six commits, with stub checks) and once plain. Done when a `--collect-only` of `tests/graph/test_per_group_unstubbed.py` shows `time_limit(300)` on both cases, no file under `src/` changes, and the failing test and the confirmed modules below… Unit: fix-test-tests-graph-test-per-group-unstubbed-py-test-one-pai-67d61268/1 * fix: Hold the graph-pass helpers build, built, built_after_a_pair and piece_built to the loaded test time limit (review round 1) Unit: fix-test-tests-graph-test-per-group-unstubbed-py-test-one-pai-67d61268/1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PRs 965 and 966 were stacked on the branch of PR 961, which had already been squash-merged, so they merged into that branch and never reached main. This re-applies them on main:
Tests in the affected files pass (48) and pre-commit is clean. Merging this lets red-check-runs-workspace-members/1 and js-red-check-accepts-a-thrown-error/1 leave their merge gates.