Skip to content

kit-has-a-core-package/3: The orchestration design document's package table lists the core's modules - #980

Merged
bwmatson merged 2 commits into
mainfrom
spec/kit-has-a-core-package/3
Nov 16, 2026
Merged

bwmatson merged 2 commits into
mainfrom
spec/kit-has-a-core-package/3

Conversation

@bwmatson

Copy link
Copy Markdown
Owner

Start here

Already verified by the pipeline

  • Tests were committed first and seen to fail first.
  • unit-test result: passed
  • Review took 1 review round

Review tier: auto — no recorded fact gives a floor above auto

Why

This pull request builds part of change kit-has-a-core-package; this is the change's reason.

The kit's design makes it three packages in one uv workspace so the worker image can carry the worker and the core and no round code, and so the store, coordination and queue interfaces are written once, in the core. The kit is one package today, so none of that can start. This change creates the workspace and the core package, which holds the 237 modules (71,000 lines) both sides import, using the module table of worker-stops-importing-the-orchestrator (its boundary test has no baseline by then).

What this pull request does

Adds a test that keeps the orchestration design's package table placing the runtimes, sandboxes, toolchain profiles and policy hooks in the core package only.

  • New tests read the ## Three packages table in docs/designs/orchestration.md and fail if it does not have exactly one row each for the core, orchestrator and worker packages.
  • For each of runtimes, sandboxes, profiles and hooks, one test fails if the core row stops naming it, and another fails if the orchestrator or worker row names it.

Based on main, with nothing unmerged beneath it — ready to merge whenever the checks look right.

Unit kit-has-a-core-package/3 of change kit-has-a-core-package, task group(s) 3.
Spec: openspec/changes/kit-has-a-core-package/ in the planning repo.

Assumptions

This unit assumes nothing unmerged: everything it builds on is already in main.

Verification

This is a unit-test unit: everything it needs is fakes, fixtures or throwaway containers, so GitHub Actions runs the whole of it. No e2e-test run was required.

Left for later

Approved, with these recorded rather than blocking:

  • tests/test_design_package_table.py:1 — This test checks a design document but sits at the top of tests/ rather than under tests/docs/. That folder holds most of the newer document tests, including tests/docs/test_worker_cutover_docs.py, which already reads docs/designs/orchestration.md.

How this was built

Tests were committed first and seen to fail before any implementation existed; the commit order is checked mechanically; lint, formatting and types pass at the tip.


Opened by the spec-driven pipeline. The build agent never merges. The pipeline merges only
a unit review classified auto and policy allowed; a person merges any other, after checking
the stack order above.

The tests come first and fail until the implementation.

The kit's design makes it three packages in one uv workspace so the worker image can carry the worker and the core and no round code, and so the store, coordination and queue interfaces are written…

Unit: kit-has-a-core-package/3
With this in, the tests of the previous commit pass.

The kit's design makes it three packages in one uv workspace so the worker image can carry the worker and the core and no round code, and so the store, coordination and queue interfaces are written…

The tests for this group pass without further implementation: the implementation already exists.

Already built, the builder's account:
All 8 cases in `tests/test_design_package_table.py` pass, and lint, format and types pass on that file and on `docs/designs/orchestration.md`.

The rebase had already left `docs/designs/orchestration.md` in the state the tests need. Main's version of the package table lists the runtimes, sandboxes, toolchain profiles and policy hooks under the core, and the worker and orchestrator rows don't name them. So I made no further edits, and the working tree has no changes of its own. I didn't weaken any test, and no stub was involved. I added no changelog entry, because nothing a user sees changes. I ran only this file, not the whole suite.

Unit: kit-has-a-core-package/3
Already-built: yes
@bwmatson bwmatson added change-kit-has-a-core-package The change this pull request belongs to checking In review, but its checks are still running review-auto Review found nothing that needs a person in-review Built and waiting for human review and removed checking In review, but its checks are still running labels Nov 16, 2026
@bwmatson
bwmatson merged commit 90d1a2e into main Nov 16, 2026
5 checks passed
@bwmatson
bwmatson deleted the spec/kit-has-a-core-package/3 branch November 16, 2026 18:00
@bwmatson bwmatson added settling Merged; waiting for its checks to complete and removed in-review Built and waiting for human review settling Merged; waiting for its checks to complete labels Nov 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

change-kit-has-a-core-package The change this pull request belongs to review-auto Review found nothing that needs a person

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant