Repository navigation
kit-has-a-core-package/3: The orchestration design document's package table lists the core's modules - #980
Merged
Conversation
The tests come first and fail until the implementation. The kit's design makes it three packages in one uv workspace so the worker image can carry the worker and the core and no round code, and so the store, coordination and queue interfaces are written… Unit: kit-has-a-core-package/3
With this in, the tests of the previous commit pass. The kit's design makes it three packages in one uv workspace so the worker image can carry the worker and the core and no round code, and so the store, coordination and queue interfaces are written… The tests for this group pass without further implementation: the implementation already exists. Already built, the builder's account: All 8 cases in `tests/test_design_package_table.py` pass, and lint, format and types pass on that file and on `docs/designs/orchestration.md`. The rebase had already left `docs/designs/orchestration.md` in the state the tests need. Main's version of the package table lists the runtimes, sandboxes, toolchain profiles and policy hooks under the core, and the worker and orchestrator rows don't name them. So I made no further edits, and the working tree has no changes of its own. I didn't weaken any test, and no stub was involved. I added no changelog entry, because nothing a user sees changes. I ran only this file, not the whole suite. Unit: kit-has-a-core-package/3 Already-built: yes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Start here
Already verified by the pipeline
Review tier:
auto— no recorded fact gives a floor above autoWhy
This pull request builds part of change kit-has-a-core-package; this is the change's reason.
The kit's design makes it three packages in one uv workspace so the worker image can carry the worker and the core and no round code, and so the store, coordination and queue interfaces are written once, in the core. The kit is one package today, so none of that can start. This change creates the workspace and the core package, which holds the 237 modules (71,000 lines) both sides import, using the module table of
worker-stops-importing-the-orchestrator(its boundary test has no baseline by then).What this pull request does
Adds a test that keeps the orchestration design's package table placing the runtimes, sandboxes, toolchain profiles and policy hooks in the core package only.
## Three packagestable indocs/designs/orchestration.mdand fail if it does not have exactly one row each for the core, orchestrator and worker packages.Based on
main, with nothing unmerged beneath it — ready to merge whenever the checks look right.Unit
kit-has-a-core-package/3of change kit-has-a-core-package, task group(s) 3.Spec:
openspec/changes/kit-has-a-core-package/in the planning repo.Assumptions
This unit assumes nothing unmerged: everything it builds on is already in
main.Verification
This is a unit-test unit: everything it needs is fakes, fixtures or throwaway containers, so GitHub Actions runs the whole of it. No e2e-test run was required.
Left for later
Approved, with these recorded rather than blocking:
tests/rather than undertests/docs/. That folder holds most of the newer document tests, includingtests/docs/test_worker_cutover_docs.py, which already readsdocs/designs/orchestration.md.How this was built
Tests were committed first and seen to fail before any implementation existed; the commit order is checked mechanically; lint, formatting and types pass at the tip.
Opened by the spec-driven pipeline. The build agent never merges. The pipeline merges only
a unit review classified
autoand policy allowed; a person merges any other, after checkingthe stack order above.