You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
fix(action-parser): preserve commas in quoted arguments - #2053
The action argument splitter only recognizes single-quoted strings, despite the value parser accepting both quote styles. For example, type(content="Hello, world!") loses everything after the comma, and click(start_box="(100,200)") produces [0.1] instead of a complete point.
Handle both quote styles and escaped quotes when splitting arguments. Preserve existing raw escape sequences and equals signs. Correct the existing double-quoted coordinate test to assert both coordinates rather than the truncated result.
Validation:
Original splitter: 5 new regressions fail, 2 controls pass.
Both source parser suites: 33 passed, repeated after restoring the final diff.
Shared package and action-parser package builds, package TypeScript check, scoped ESLint, Prettier, and diff checks pass.
Built package's public CJS entry also parses the full double-quoted content and point correctly.
The full package test command has an existing EISDIR import error in test/index.test.ts (from '../'). It occurs with the unchanged source and this patch; it is not hidden or claimed passing.
No UI changes or new dependencies. Agent-assisted contribution.
Checklist
Added or updated necessary tests (Optional).
Updated documentation to align with changes (Optional).
Verified no breaking changes, or prepared solutions for any occurring breaking changes (Optional).
Could a maintainer review the quoted-comma parser fix and help unblock the fork checks?
Head 129adcb2 is unchanged. Today's focused parser rerun passes 33 tests, including both parser entry points, quoted commas/escaped quotes and the existing coordinate cases.
The Actions view exposes a gate not reflected by the successful CLA/rollup: CI Test, Typecheck and secretlint have startup_failure with no check runs; E2E and secret-scan need fork approval. There are no logs identifying a source-level failure, so I am not treating that startup result as a failing parser test.
Related #1871 is also waiting on maintainer review/check startup; its previously recorded CDP tests/type checks and scope remain in that description. Grouping the request here rather than adding another notification. The existing whole-package import limitation remains disclosed; no desktop/model E2E is claimed. AI-assisted implementation and validation.
This branch has not been deployed
No deployments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The action argument splitter only recognizes single-quoted strings, despite the value parser accepting both quote styles. For example,
type(content="Hello, world!")loses everything after the comma, andclick(start_box="(100,200)")produces[0.1]instead of a complete point.Handle both quote styles and escaped quotes when splitting arguments. Preserve existing raw escape sequences and equals signs. Correct the existing double-quoted coordinate test to assert both coordinates rather than the truncated result.
Validation:
EISDIRimport error intest/index.test.ts(from '../'). It occurs with the unchanged source and this patch; it is not hidden or claimed passing.No UI changes or new dependencies. Agent-assisted contribution.
Checklist