Skip to content

fix(action-parser): preserve commas in quoted arguments - #2053

Open
Ricardo-M-L wants to merge 1 commit into
bytedance:mainfrom
Ricardo-M-L:fix/parser-quoted-commas-batch11-20261023
Open

Ricardo-M-L wants to merge 1 commit into
bytedance:mainfrom
Ricardo-M-L:fix/parser-quoted-commas-batch11-20261023

Conversation

@Ricardo-M-L

Copy link
Copy Markdown

Summary

The action argument splitter only recognizes single-quoted strings, despite the value parser accepting both quote styles. For example, type(content="Hello, world!") loses everything after the comma, and click(start_box="(100,200)") produces [0.1] instead of a complete point.

Handle both quote styles and escaped quotes when splitting arguments. Preserve existing raw escape sequences and equals signs. Correct the existing double-quoted coordinate test to assert both coordinates rather than the truncated result.

Validation:

  • Original splitter: 5 new regressions fail, 2 controls pass.
  • Both source parser suites: 33 passed, repeated after restoring the final diff.
  • Shared package and action-parser package builds, package TypeScript check, scoped ESLint, Prettier, and diff checks pass.
  • Built package's public CJS entry also parses the full double-quoted content and point correctly.
  • The full package test command has an existing EISDIR import error in test/index.test.ts (from '../'). It occurs with the unchanged source and this patch; it is not hidden or claimed passing.

No UI changes or new dependencies. Agent-assisted contribution.

Checklist

  • Added or updated necessary tests (Optional).
  • Updated documentation to align with changes (Optional).
  • Verified no breaking changes, or prepared solutions for any occurring breaking changes (Optional).
  • My change does not involve the above items.

@netlify

netlify Bot commented Oct 22, 2026 •

Copy link
Copy Markdown

✅ Deploy Preview for agent-tars-docs canceled.

Name Link
🔨 Latest commit 129adcb
🔍 Latest deploy log https://app.netlify.com/projects/agent-tars-docs/deploys/6ada40e635abd73332ee3c94

@netlify

netlify Bot commented Oct 22, 2026 •

Copy link
Copy Markdown

✅ Deploy Preview for tarko canceled.

Name Link
🔨 Latest commit 129adcb
🔍 Latest deploy log https://app.netlify.com/projects/tarko/deploys/6ada40e61711e1914a971037

@Ricardo-M-L

Copy link
Copy Markdown
Author

Could a maintainer review the quoted-comma parser fix and help unblock the fork checks?

Head 129adcb2 is unchanged. Today's focused parser rerun passes 33 tests, including both parser entry points, quoted commas/escaped quotes and the existing coordinate cases.

The Actions view exposes a gate not reflected by the successful CLA/rollup: CI Test, Typecheck and secretlint have startup_failure with no check runs; E2E and secret-scan need fork approval. There are no logs identifying a source-level failure, so I am not treating that startup result as a failing parser test.

Related #1871 is also waiting on maintainer review/check startup; its previously recorded CDP tests/type checks and scope remain in that description. Grouping the request here rather than adding another notification. The existing whole-package import limitation remains disclosed; no desktop/model E2E is claimed. AI-assisted implementation and validation.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant