Skip to content

Fix/update readme badges#549

Closed
CKodidela wants to merge 1 commit intocameri:mainfrom
CKodidela:fix/update-readme-badges
Closed

Fix/update readme badges#549
CKodidela wants to merge 1 commit intocameri:mainfrom
CKodidela:fix/update-readme-badges

Conversation

@CKodidela
Copy link
Copy Markdown
Collaborator

Description

Remove the SonarQube badge from README.md and update the Coveralls badge to point to the correct repository and branch.

Related Issue

Fixes #531

Motivation and Context

The SonarQube badge is no longer maintained or relevant. The Coveralls badge URL needed to be corrected to use the canonical lowercase repository path (cameri/nostream) so the badge resolves properly.

How Has This Been Tested?

This is a docs-only change. No code was modified. Badge URLs were verified manually.

Screenshots (if appropriate):

N/A

Types of changes

  • Non-functional change (docs, style, minor refactor)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my code changes.
  • I added a changeset, or this is docs-only and I added an empty changeset.
  • All new and existing tests passed.

Copilot AI review requested due to automatic review settings April 20, 2026 05:03
@CKodidela CKodidela force-pushed the fix/update-readme-badges branch from 261aabc to 1a35ce6 Compare April 20, 2026 05:05
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates repository badges in README.md and expands subscription filter schema validation to accept uppercase single-letter tag query keys (e.g. #E, #K) alongside lowercase ones, with accompanying docs/tests.

Changes:

  • Remove the Sonar badge and correct the Coveralls badge URLs to the canonical repo path.
  • Update filterSchema validation to use isGenericTagQuery (supporting #A#Z as well as #a#z) and add unit tests.
  • Document uppercase tag filter scope in CONFIGURATION.md and add a patch changeset.

Reviewed changes

Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
test/unit/schemas/filter-schema.spec.ts Adds unit tests covering uppercase tag filter acceptance.
src/schemas/filter-schema.ts Updates unknown-key validation to allow generic tag queries via isGenericTagQuery.
README.md Removes Sonar badge and fixes Coveralls badge links.
CONFIGURATION.md Updates index documentation and adds a section describing uppercase/lowercase tag filter scope.
.changeset/uppercase-tag-filters.md Adds a patch changeset for uppercase tag filter support.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread README.md
Comment on lines +24 to 26
<a href='https://coveralls.io/github/cameri/nostream?branch=main'>
<img alt='Coverage Status' src='https://coveralls.io/repos/github/cameri/nostream/badge.svg?branch=main' />
</a>
Copy link

Copilot AI Apr 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR metadata says this is a docs-only change focused on README badges, but this diff also includes behavior changes (filter schema validation) plus unit tests and a patch changeset. Please update the PR title/description/testing notes (and/or split into separate PRs) so reviewers and release notes match the actual scope.

Copilot uses AI. Check for mistakes.
@CKodidela CKodidela closed this Apr 20, 2026
@coveralls
Copy link
Copy Markdown
Collaborator

coveralls commented Apr 20, 2026

Coverage Status

coverage: 73.153%. remained the same — CKodidela:fix/update-readme-badges into cameri:main

@CKodidela CKodidela deleted the fix/update-readme-badges branch April 20, 2026 05:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update README: remove Sonarqube badge, update Coveralls badge

3 participants