Fix/update readme badges#549
Conversation
261aabc to
1a35ce6
Compare
There was a problem hiding this comment.
Pull request overview
This PR updates repository badges in README.md and expands subscription filter schema validation to accept uppercase single-letter tag query keys (e.g. #E, #K) alongside lowercase ones, with accompanying docs/tests.
Changes:
- Remove the Sonar badge and correct the Coveralls badge URLs to the canonical repo path.
- Update
filterSchemavalidation to useisGenericTagQuery(supporting#A–#Zas well as#a–#z) and add unit tests. - Document uppercase tag filter scope in
CONFIGURATION.mdand add a patch changeset.
Reviewed changes
Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| test/unit/schemas/filter-schema.spec.ts | Adds unit tests covering uppercase tag filter acceptance. |
| src/schemas/filter-schema.ts | Updates unknown-key validation to allow generic tag queries via isGenericTagQuery. |
| README.md | Removes Sonar badge and fixes Coveralls badge links. |
| CONFIGURATION.md | Updates index documentation and adds a section describing uppercase/lowercase tag filter scope. |
| .changeset/uppercase-tag-filters.md | Adds a patch changeset for uppercase tag filter support. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| <a href='https://coveralls.io/github/cameri/nostream?branch=main'> | ||
| <img alt='Coverage Status' src='https://coveralls.io/repos/github/cameri/nostream/badge.svg?branch=main' /> | ||
| </a> |
There was a problem hiding this comment.
The PR metadata says this is a docs-only change focused on README badges, but this diff also includes behavior changes (filter schema validation) plus unit tests and a patch changeset. Please update the PR title/description/testing notes (and/or split into separate PRs) so reviewers and release notes match the actual scope.
Description
Remove the SonarQube badge from README.md and update the Coveralls badge to point to the correct repository and branch.
Related Issue
Fixes #531
Motivation and Context
The SonarQube badge is no longer maintained or relevant. The Coveralls badge URL needed to be corrected to use the canonical lowercase repository path (
cameri/nostream) so the badge resolves properly.How Has This Been Tested?
This is a docs-only change. No code was modified. Badge URLs were verified manually.
Screenshots (if appropriate):
N/A
Types of changes
Checklist: