Skip to content

Handle empty validator set in monitoring#437

Open
giwaov wants to merge 1 commit into
canopy-network:mainfrom
giwaov:issue-431-monitoring-empty-validator-set
Open

Handle empty validator set in monitoring#437
giwaov wants to merge 1 commit into
canopy-network:mainfrom
giwaov:issue-431-monitoring-empty-validator-set

Conversation

@giwaov

@giwaov giwaov commented Jun 28, 2026

Copy link
Copy Markdown

Summary

  • Preserve RPC error metadata in the wallet DS fetcher so callers can inspect server error codes.
  • Treat validator-set error code 29 as an empty validator set in monitoring data loading.
  • Keep other validator-set and monitoring fetch failures fatal.

Why

Fixes #431. A chain with no staked committee validators returns the canonical no-validators response, but the monitoring page treated it as a fatal RPC 400 and hid the other data that loaded successfully.

Testing

  • npm run build
  • git diff --check

@giwaov

giwaov commented Jul 4, 2026

Copy link
Copy Markdown
Author

Hi maintainers, could you please take a look when you have a chance? This one addresses the reported monitoring-page failure for empty validator sets and keeps the rest of the monitoring data visible. I’m happy to adjust the scope if you’d prefer a different handling for code 29.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

wallet: /monitoring page surfaces 'RPC 400' fatal error on validator-set returning code 29 (no validators in the set)

1 participant