Switch to using v145 as the default compiler for Windows - #12
Open
filipppavlov wants to merge 5 commits into
Open
Switch to using v145 as the default compiler for Windows#12filipppavlov wants to merge 5 commits into
filipppavlov wants to merge 5 commits into
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the Windows build configuration to default to the v145 toolset (and corresponding vcpkg toolchain/triplets), and applies a set of C++ include fixes to resolve stricter compiler/header requirements when building with v145 on Windows.
Changes:
- Update Windows CMake preset to chainload the
x64-windows-145vcpkg toolchain and usex64-windows-145-*triplets. - Update TeamCity Windows build bootstrap to call a configurable VS dev environment script with switches targeting the v145 toolset.
- Fix Windows/v145 compilation issues by adding missing standard library headers in several C++ sources/headers.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/viewer/rendering/vulkan/texture.cpp | Adds a missing standard header include needed for compilation. |
| src/viewer/rendering/vulkan/shadercache.cpp | Adds a missing standard header include needed for compilation. |
| src/viewer/rendering/ui/uiCustomWidgets.h | Adds a missing standard header include needed for compilation. |
| src/viewer/rendering/renderable/geometryprepass.cpp | Adds a missing standard header include needed for compilation. |
| src/viewer/data/cmfcontent.h | Adds missing standard header includes needed for compilation. |
| src/processor/cmffile.cpp | Adds a missing standard header include needed for compilation. |
| CMakePresets.json | Switches Windows preset/toolchain + vcpkg triplets to the -145- variants. |
| .teamcity/Windows/Project.kt | Updates Windows CI bootstrap to use a configurable VS dev cmd path + switches (v145-oriented). |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update CMakePresets.json and TC config to use v145 compiler when building for Windows. Fix compile errors when building with v145.