Skip to content

Rails support for Rails 4.2 - #57

Open
jtapia wants to merge 6 commits into
masterfrom
rails-testing
Open

Rails support for Rails 4.2#57
jtapia wants to merge 6 commits into
masterfrom
rails-testing

Conversation

@jtapia

@jtapia jtapia commented May 1, 2015

Copy link
Copy Markdown
Collaborator
  • Update gems
  • Update Ruby and Rails versions
  • Update README

ecbypi and others added 3 commits April 20, 2015 11:12
* Drop testing on ruby 1.9.2
* Add appraisals for Rails 3.0 - 4.2
* Get tests passing on Rails 4.2.x
@ecbypi

ecbypi commented May 1, 2015

Copy link
Copy Markdown
Contributor

It's still failing because it thinks the Gemfile has been changed. I'm not sure why, but it would be nice to see if it's reproducible on your local dev environment.

I would take out updating the version. I think it's best to keep the feature change independent of incrementing the version so features can be reverted without affecting the version number.

@jtapia

jtapia commented May 1, 2015

Copy link
Copy Markdown
Collaborator Author

@ecbypi got it, and done, I removed the update of version

@jtapia

jtapia commented May 1, 2015

Copy link
Copy Markdown
Collaborator Author

I can't reproduce it locally, and neither send the new Gemfile.lock, because maybe we're using different versions

@ecbypi

ecbypi commented May 13, 2015

Copy link
Copy Markdown
Contributor

@jtapia, found another instance of the bundler problem. Searching through bundler's issues, I'm able to find issues with a similar error message, but nothing that exactly mirrors our problem. I'm trying to run the build with an updated version of bundler.

http://stackoverflow.com/questions/26221540/gemspec-modification-up-to-date-gemfile-lock-does-break-the-travis-ci-build-d

@jtapia

jtapia commented May 13, 2015

Copy link
Copy Markdown
Collaborator Author

@ecbypi Ok, let me take a look and see if I can find a solution, is it for Travis CI, right?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants