feat: implement sequencer recovery for stale batches#12
Draft
feat: implement sequencer recovery for stale batches#12
Conversation
GCdePaula
force-pushed
the
feature/recovery
branch
from
97d62d2 to
c0c0810
Compare
Refine TLA+ model Add more tests
GCdePaula
force-pushed
the
feature/recovery
branch
from
f597e0d to
dcd2e86
Compare
GCdePaula
force-pushed
the
feature/recovery
branch
from
0bab3cf to
dd3a554
Compare
Extract DangerDetector as its own worker; submitter is pure submission. Unify SchedulerRules + RecoveryParams into one ProtocolConfig in core. Pure decide_submit_start + decide_startup_action with exhaustive tests. DangerZone is a deliberate RunError variant, not a BatchSubmitterError.
GCdePaula
force-pushed
the
feature/recovery
branch
from
dcc6bff to
b879624
Compare
Transactions use read/write closures; 11 manual sites collapsed. internals.rs split into convert/queries/mutations; drop load_ prefix. pending_batches now bakes the authoritative nonce into wire bytes. Extract 2000-line test block from recovery.rs into a sibling file. Improve flusher error handling
GCdePaula
force-pushed
the
feature/recovery
branch
from
b879624 to
4a592fe
Compare
stephenctw
reviewed
Apr 29, 2026
Collaborator
stephenctw
left a comment
stephenctw
left a comment
There was a problem hiding this comment.
Looks great! I've left a few minor comments.
| }); | ||
| } | ||
| Ok(_) => {} // verified | ||
| Err(e) => { |
Collaborator
There was a problem hiding this comment.
Could we fail startup if get_chain_id() errors here? Right now we warn+continue, which can skip chain-id validation on transient RPC issues.
| /// zero would make preemptive recovery indistinguishable from hard | ||
| /// staleness. Callers should catch this at startup. | ||
| pub fn danger_threshold(&self) -> u64 { | ||
| assert!( |
Collaborator
There was a problem hiding this comment.
this assert! panics on invalid operator config. Would you consider returning a typed startup config error instead (still fail-fast, just cleaner)?
| batch_submitter_address = %l1_config.batch_submitter_address, | ||
| max_wait_blocks = protocol.max_wait_blocks, | ||
| preemptive_margin_blocks = protocol.preemptive_margin_blocks, | ||
| danger_threshold = protocol.danger_threshold(), |
Collaborator
There was a problem hiding this comment.
Related to above: calling danger_threshold() in startup logging means invalid config panics before structured error handling. Maybe validate once up front and return a typed error.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.