feat(mint): Add Spark L2 wallet backend#1019
Conversation
…and correctly converts to sats
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1019 +/- ##
==========================================
- Coverage 75.03% 73.49% -1.54%
==========================================
Files 111 112 +1
Lines 12239 12529 +290
==========================================
+ Hits 9183 9208 +25
- Misses 3056 3321 +265 ☔ View full report in Codecov by Harness. |
…ributeError on incoming payments
…L2 event listener to prevent uniffi crashes
| # We run this in a thread because breez SDK connect is blocking in python (currently) | ||
| # Actually, `connect` is async in Python. Let's await it. | ||
| # wait, breez_sdk_spark python binding functions are actually async? No they are sync. | ||
| if inspect.iscoroutinefunction(breez_sdk_spark.connect): |
There was a problem hiding this comment.
this is horrible and should be part of the codebase as well.
| ) | ||
|
|
||
| req = breez_sdk_spark.GetInfoRequest(ensure_synced=False) | ||
| if inspect.iscoroutinefunction(self.sdk.get_info): |
There was a problem hiding this comment.
same here. figure this out this from the documentation.
…rounds in Breez SDK integration
|
Thanks for the feedback! I've removed all |
…t all exceptions as PENDING
fix(sparkl2): prevent description_hash from being used as payment_hash
… siphoning attacks
|
@callebtc Should we derive a mnemonic from the mint private key, or should we let it as is where the operator specifies a mnemonic for the breeze sdk as well as the secret for the mint? |
2 participants
A