fix(wallet): handle unpaid invoices in the CLI invoice command#1022
Open
edgarmuyomba wants to merge 1 commit into
Open
fix(wallet): handle unpaid invoices in the CLI invoice command#1022edgarmuyomba wants to merge 1 commit into
edgarmuyomba wants to merge 1 commit into
Conversation
Fixes cashubtc#1021 - Add timeout to websocket wait loop using mint quote expiry, preventing indefinite hang when invoice is never paid - Guard "Invoice paid" output behind paid state check so it only prints when minting actually succeeded
Contributor
|
Faced similar issue |
Contributor
|
Tested locally and confirmed
Test setup: local mint with websocket support, unpaid invoice (e.g. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1021
Summary
Testing
Tested by setting
fakewallet_brr=Falseto disable auto invoice payment, then runningcashu invoice 99and waiting ~10 minutes.Console correctly output "Invoice is not paid yet, stopping check..." with no misleading "Invoice paid" message.