Skip to content

fix: use UUIDv7 for quote and subscription IDs#1023

Merged
callebtc merged 2 commits into
mainfrom
quote-ids-uuid-v7
Jun 7, 2026
Merged

fix: use UUIDv7 for quote and subscription IDs#1023
callebtc merged 2 commits into
mainfrom
quote-ids-uuid-v7

Conversation

@callebtc

@callebtc callebtc commented May 28, 2026

Copy link
Copy Markdown
Collaborator

Implements cashubtc/nuts#383

Summary

  • use a shared generate_uuid_v7() helper for UUIDv7 generation
  • switch mint quote IDs and melt quote IDs to UUIDv7
  • switch websocket subscription IDs to UUIDv7
  • remove the old quote-specific/random hash helper usage

Testing

  • poetry run pytest -q tests/test_quote_ids.py tests/wallet/test_wallet_subscription_unit.py tests/wallet/test_wallet.py::test_request_mint tests/wallet/test_wallet.py::test_mint tests/wallet/test_wallet.py::test_melt tests/wallet/test_wallet.py::test_get_melt_quote_state tests/test_mint_rpc_cli.py::test_get_mint_quote tests/test_mint_rpc_cli.py::test_get_melt_quote tests/test_mint_rpc_cli.py::test_get_quote_ttl_mint_quote tests/test_mint_rpc_cli.py::test_get_quote_ttl_melt_quote

@codecov

codecov Bot commented May 28, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 75.05%. Comparing base (31e3ae3) to head (e2bfea1).
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1023      +/-   ##
==========================================
+ Coverage   75.03%   75.05%   +0.02%     
==========================================
  Files         111      111              
  Lines       12239    12245       +6     
==========================================
+ Hits         9183     9190       +7     
+ Misses       3056     3055       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@callebtc callebtc merged commit f6add15 into main Jun 7, 2026
30 checks passed
@github-project-automation github-project-automation Bot moved this from Backlog to Done in nutshell Jun 7, 2026
edgarmuyomba pushed a commit to edgarmuyomba/nutshell that referenced this pull request Jun 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants