Skip to content

fix: verify_proofs_dleq should not early return#964

Open
robwoodgate wants to merge 2 commits into
cashubtc:mainfrom
robwoodgate:fix/dleq-verification
Open

fix: verify_proofs_dleq should not early return#964
robwoodgate wants to merge 2 commits into
cashubtc:mainfrom
robwoodgate:fix/dleq-verification

Conversation

@robwoodgate

Copy link
Copy Markdown
Contributor

Fixes a bug where first proof without DLEQ silently skipped verification of all remaining proofs.

verify_proofs_dleq now checks all proofs have vaiid DLEQ.

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, you can upgrade your account or add credits to your account and enable them for code reviews in your settings.

@codecov

codecov Bot commented Mar 31, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 75.21%. Comparing base (a1ff72c) to head (950fdf6).
⚠️ Report is 2 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #964      +/-   ##
==========================================
+ Coverage   74.90%   75.21%   +0.30%     
==========================================
  Files          99       99              
  Lines       11685    11714      +29     
==========================================
+ Hits         8753     8811      +58     
+ Misses       2932     2903      -29     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@a1denvalu3

Copy link
Copy Markdown
Collaborator

lgtm

@b-l-u-e

b-l-u-e commented Mar 31, 2026

Copy link
Copy Markdown
Contributor

just thought but i think worth adding test the bug was subtle control flow return vs continue.
a test that mixes a proof without DLEQ and one with invalid DLEQ would lock in the intended behavior.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Backlog

Development

Successfully merging this pull request may close these issues.

3 participants