-
Notifications
You must be signed in to change notification settings - Fork 484
Add .NET 10 to test matrix #724
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
looks like we have unstable tests |
src/Castle.Core.Tests.WeakNamed/Castle.Core.Tests.WeakNamed.csproj
Outdated
Show resolved
Hide resolved
Yes we do (I'll gladly accept a PR that fixes it without just disabling the test). That's quite a frequent occurrence with this project, hence my reluctance to tinker with the CI build too often. 😉 |
|
Btw. if we were doing this 100% correctly, we would be adding a .NET 10 test run to AppVeyor CI also (which at this time is the leading CI). |
yes, or maybe better to drop tests from AppVeyor an use it only for release if you don't want to remove it now? |
@Romfos, I've said it before but this is currently not an option. You may dislike it, but AppVeyor is currently the leading CI system for this project, and it is also the CI system responsible for publishing NuGet packages. Therefore it is imperative that we keep safeguards in place to avoid publishing faulty packages, and those safeguards are the AppVeyor test runs. I would like to kindly ask you to stop repeatedly questioning the role of AppVeyor for this project, it's a waste of our time since for the moment we are still stuck with it, and I think we all agree that it's on its way out eventually. Until then, let's not make things worse by taking unnecessary shortcuts. |
|
Merged. Thank you, @Romfos! |
Changes: