feat(model): add harmonization extension models and validation (v7) - #306
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Adds a new openepd.model.ext.harmonization extension package (v7) that models multiple harmonization factor types and provides validation + serialization behavior, with unit tests covering parsing from Epd.ext.
Changes:
- Introduce harmonization factor base models (lifecycle-module deltas, impacts/resource/output structures).
- Add concrete harmonization factor models for coproducts, EAC, MBVFA, offsets, plus support for custom (extra) factors.
- Add unittest-based coverage for parsing, enum validation, schema constraints, and custom-factor extra typing.
Reviewed changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/openepd/model/ext/init.py | Establishes the ext package namespace. |
| src/openepd/model/ext/harmonization/init.py | Re-exports harmonization extension public API. |
| src/openepd/model/ext/harmonization/base.py | Defines shared harmonization factor base schema and lifecycle-module delta structures. |
| src/openepd/model/ext/harmonization/coproducts.py | Adds coproduct allocation enums and factor model. |
| src/openepd/model/ext/harmonization/custom.py | Defines the custom harmonization factor payload model. |
| src/openepd/model/ext/harmonization/eac.py | Adds EAC enums and factor model with aliased EAC_* fields. |
| src/openepd/model/ext/harmonization/mbvfa.py | Adds MBVFA enums and factor model. |
| src/openepd/model/ext/harmonization/offsets.py | Adds offset enums and factor model. |
| src/openepd/model/ext/harmonization/ext.py | Adds the top-level HarmonizationEpdExtension wiring for known factor types + extra custom factors. |
| src/openepd/model/ext/harmonization/tests/init.py | Establishes harmonization test package. |
| src/openepd/model/ext/harmonization/tests/test_harmonization_ext.py | Adds tests for parsing/serialization/validation across factor types and custom extra behavior. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
alexlitvinenko
force-pushed
the
feat/harmonization-ext-v7
branch
from
August 13, 2026 13:05
c6b9058 to
74dd398
Compare
alexlitvinenko
force-pushed
the
feat/harmonization-ext-v7
branch
from
August 13, 2026 13:07
74dd398 to
4f772dc
Compare
Introduce a harmonization extension package with factor modules for coproducts, custom, EAC, MBVFA, and offsets. Add extension wiring and tests for harmonization behavior. asana: [[BE] Support harmonization EPD extension](https://app.asana.com/1/654700433662128/project/666075018299960/task/1217139741601651?focus=true)
alexlitvinenko
force-pushed
the
feat/harmonization-ext-v7
branch
from
August 13, 2026 14:22
4f772dc to
45fb4b9
Compare
bohdanzahoruikocchangelabs
approved these changes
Aug 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduce a harmonization extension package with factor modules for coproducts, custom, EAC, MBVFA, and offsets.
Add extension wiring and tests for harmonization behavior.
asana: [BE] Support harmonization EPD extension