Skip to content

Patch transitive undici to 7.28.0 for GHSA-pr7r-676h-xcf6#163

Merged
jcstein merged 3 commits into
mainfrom
copilot/fix-undici-cache-vulnerability
Jun 18, 2026
Merged

Patch transitive undici to 7.28.0 for GHSA-pr7r-676h-xcf6#163
jcstein merged 3 commits into
mainfrom
copilot/fix-undici-cache-vulnerability

Conversation

Copilot AI commented Jun 18, 2026

Copy link
Copy Markdown
Contributor

Dependabot flagged undici@7.24.8 (CVE-2026-9678 / GHSA-pr7r-676h-xcf6), where whitespace handling in qualified private/no-cache directives can cause incorrect shared-cache behavior. This PR pins the dependency graph to the minimum patched version (7.28.0) with minimal blast radius.

  • Dependency remediation

    • Added a workspace-level pnpm override to force undici to 7.28.0.
    • Regenerated pnpm-lock.yaml so transitive resolution no longer includes 7.24.8 (via wrangler -> miniflare).
  • Reachability assessment

    • Advisory scope: Undici cache interceptor in shared-cache mode (interceptors.cache()) with auth-bearing traffic.
    • Repo scan found no undici usage and no interceptors.cache() call sites; only an Authorization CORS allow-header in worker/index.js.
    • Conclusion: vulnerable code path is not reachable in this codebase; update is primarily scanner remediation.
    • Confidence: High.
  • Config change (example)

    # pnpm-workspace.yaml
    overrides:
      esbuild: 0.28.1
      undici: 7.28.0
Original prompt

This section details the Dependabot vulnerability alert you should resolve

<alert_title>undici vulnerable to cross-user information disclosure via shared cache whitespace bypass</alert_title>
<alert_description>## Impact

Undici's cache interceptor incorrectly classifies some responses as cacheable when the upstream Cache-Control header uses whitespace-padded qualified private or no-cache field names such as private=" authorization" or no-cache="\tauthorization". The parser preserves the surrounding whitespace, so later comparisons against the literal authorization field name fail and the response is stored.

In shared-cache mode, this allows a response containing one user's authenticated data to be served from cache to a subsequent caller, including an unauthenticated caller, when both requests resolve to the same cache key.

Affected applications are those that explicitly enable the cache interceptor (interceptors.cache()) in shared mode, forward Authorization headers upstream, and receive cacheable responses with non-canonical qualified private or no-cache directives.

Patches

Upgrade to undici v7.28.0 or v8.5.0.

Workarounds

If upgrade is not immediately possible, disable shared-cache mode for traffic that includes Authorization headers, avoid caching responses to authenticated requests, or add Vary: Authorization upstream.</alert_description>

moderate
GHSA-pr7r-676h-xcf6, CVE-2026-9678
undici
npm
<vulnerable_versions>7.24.8</vulnerable_versions>
<patched_version>7.28.0</patched_version>
<manifest_path>pnpm-lock.yaml</manifest_path>

https://github.com/nodejs/undici/security/advisories/GHSA-pr7r-676h-xcf6 https://nvd.nist.gov/vuln/detail/CVE-2026-9678 https://cna.openjsf.org/security-advisories.html https://github.com/advisories/GHSA-pr7r-676h-xcf6

<agent_instructions>fix this on top of https://github.com/celestiaorg/eden-docs/security/dependabot/157</agent_instructions>

<task_instructions>Resolve this alert by updating the affected package to a non-vulnerable version. Prefer the lowest non-vulnerable version (see the patched_version field above) over the latest to minimize breaking changes. Include a Reachability Assessment section in the PR description. Review the alert_description field to understand which APIs, features, or configurations are affected, then search the codebase for usage of those specific items. If the vulnerable code path is reachable, explain how (which files, APIs, or call sites use the affected functionality) and note that the codebase is actively exposed to this vulnerability. If the vulnerable code path is not reachable, explain why (e.g. the affected API is never called, the vulnerable configuration is not used) and note that the update is primarily to satisfy vulnerability scanners rather than to address an active risk. If the advisory is too vague to determine reachability (e.g. 'improper input validation' with no specific API named), state that reachability could not be determined and explain why. Include a confidence level in the reachability assessment (e.g. high confidence if the advisory names a specific API and you confirmed it is or is not called, low confidence if the usage is indirect and hard to trace). If no patched version is available, check the alert_description field for a Workarounds section — the advisory may describe configuration changes or usage patterns that mitigate the vulnerability without a version update. If a workaround is available, apply it and leave a code comment referencing the advisory identifier explaining it is a temporary mitigation. If neither a patch nor a workaround is available, explain in the PR description why the alert cannot be resolved automatically so a human reviewer can take over. Inspect the repository to determine which package manager is used (e.g. lock files, config files, build scripts) and use that tooling to perform the update — do not edit lock files directly. If the version constraint in the manifest (e.g. package.json, Gemfile, pyproject.toml) caps the version below the fix, update the constraint first. For transitive dependencies, determine whether it is simpler to update the direct dependency that pulls in the vulnerable package or to update the transitive dependency directly, and choose the least disruptive approach. If upgrading to fix the vulnerability forces a major version bump or known breaking changes, review the changelog or release notes, then audit the codebase for usage of affected APIs and fix any breaking changes that are found. If the package manager fails to resolve dependencies (e.g. peer dependency conflicts, incompatible engine constraints), document the error in the PR description rather than attempting increasingly complex workarounds. After updating, check the lock file to confirm the packa...

Copilot AI changed the title [WIP] Fix undici vulnerability for cross-user information disclosure Patch transitive undici to 7.28.0 for GHSA-pr7r-676h-xcf6 Jun 18, 2026
Copilot AI requested a review from jcstein June 18, 2026 19:03
@jcstein jcstein marked this pull request as ready for review June 18, 2026 19:03
@jcstein jcstein merged commit 9eaa9aa into main Jun 18, 2026
@jcstein jcstein deleted the copilot/fix-undici-cache-vulnerability branch June 18, 2026 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants