Patch transitive undici to 7.28.0 for GHSA-pr7r-676h-xcf6#163
Merged
Conversation
Copilot
AI
changed the title
[WIP] Fix undici vulnerability for cross-user information disclosure
Patch transitive Jun 18, 2026
undici to 7.28.0 for GHSA-pr7r-676h-xcf6
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dependabot flagged
undici@7.24.8(CVE-2026-9678 / GHSA-pr7r-676h-xcf6), where whitespace handling in qualifiedprivate/no-cachedirectives can cause incorrect shared-cache behavior. This PR pins the dependency graph to the minimum patched version (7.28.0) with minimal blast radius.Dependency remediation
undicito7.28.0.pnpm-lock.yamlso transitive resolution no longer includes7.24.8(viawrangler -> miniflare).Reachability assessment
interceptors.cache()) with auth-bearing traffic.undiciusage and nointerceptors.cache()call sites; only anAuthorizationCORS allow-header inworker/index.js.Config change (example)
Original prompt
This section details the Dependabot vulnerability alert you should resolve
<alert_title>undici vulnerable to cross-user information disclosure via shared cache whitespace bypass</alert_title>
<alert_description>## Impact
Undici's cache interceptor incorrectly classifies some responses as cacheable when the upstream
Cache-Controlheader uses whitespace-padded qualifiedprivateorno-cachefield names such asprivate=" authorization"orno-cache="\tauthorization". The parser preserves the surrounding whitespace, so later comparisons against the literalauthorizationfield name fail and the response is stored.In shared-cache mode, this allows a response containing one user's authenticated data to be served from cache to a subsequent caller, including an unauthenticated caller, when both requests resolve to the same cache key.
Affected applications are those that explicitly enable the cache interceptor (
interceptors.cache()) in shared mode, forwardAuthorizationheaders upstream, and receive cacheable responses with non-canonical qualifiedprivateorno-cachedirectives.Patches
Upgrade to undici v7.28.0 or v8.5.0.
Workarounds
If upgrade is not immediately possible, disable shared-cache mode for traffic that includes
Authorizationheaders, avoid caching responses to authenticated requests, or addVary: Authorizationupstream.</alert_description>moderate
https://github.com/nodejs/undici/security/advisories/GHSA-pr7r-676h-xcf6 https://nvd.nist.gov/vuln/detail/CVE-2026-9678 https://cna.openjsf.org/security-advisories.html https://github.com/advisories/GHSA-pr7r-676h-xcf6GHSA-pr7r-676h-xcf6, CVE-2026-9678
undici
npm
<vulnerable_versions>7.24.8</vulnerable_versions>
<patched_version>7.28.0</patched_version>
<manifest_path>pnpm-lock.yaml</manifest_path>
<agent_instructions>fix this on top of https://github.com/celestiaorg/eden-docs/security/dependabot/157</agent_instructions>
<task_instructions>Resolve this alert by updating the affected package to a non-vulnerable version. Prefer the lowest non-vulnerable version (see the patched_version field above) over the latest to minimize breaking changes. Include a Reachability Assessment section in the PR description. Review the alert_description field to understand which APIs, features, or configurations are affected, then search the codebase for usage of those specific items. If the vulnerable code path is reachable, explain how (which files, APIs, or call sites use the affected functionality) and note that the codebase is actively exposed to this vulnerability. If the vulnerable code path is not reachable, explain why (e.g. the affected API is never called, the vulnerable configuration is not used) and note that the update is primarily to satisfy vulnerability scanners rather than to address an active risk. If the advisory is too vague to determine reachability (e.g. 'improper input validation' with no specific API named), state that reachability could not be determined and explain why. Include a confidence level in the reachability assessment (e.g. high confidence if the advisory names a specific API and you confirmed it is or is not called, low confidence if the usage is indirect and hard to trace). If no patched version is available, check the alert_description field for a Workarounds section — the advisory may describe configuration changes or usage patterns that mitigate the vulnerability without a version update. If a workaround is available, apply it and leave a code comment referencing the advisory identifier explaining it is a temporary mitigation. If neither a patch nor a workaround is available, explain in the PR description why the alert cannot be resolved automatically so a human reviewer can take over. Inspect the repository to determine which package manager is used (e.g. lock files, config files, build scripts) and use that tooling to perform the update — do not edit lock files directly. If the version constraint in the manifest (e.g. package.json, Gemfile, pyproject.toml) caps the version below the fix, update the constraint first. For transitive dependencies, determine whether it is simpler to update the direct dependency that pulls in the vulnerable package or to update the transitive dependency directly, and choose the least disruptive approach. If upgrading to fix the vulnerability forces a major version bump or known breaking changes, review the changelog or release notes, then audit the codebase for usage of affected APIs and fix any breaking changes that are found. If the package manager fails to resolve dependencies (e.g. peer dependency conflicts, incompatible engine constraints), document the error in the PR description rather than attempting increasingly complex workarounds. After updating, check the lock file to confirm the packa...