JavaScript: account for the fact that our JavaScript bindings use a 32-bit address space

src/analysermodel.cpp

@@ -496,25 +496,20 @@ bool AnalyserModel::areEquivalentVariables(const VariablePtr &variable1,
     // an AnalyserModel object refers to a static version of a model, which
     // means that we can safely cache the result of a call to that utility. In
     // turn, this means that we can speed up any feature (e.g., code generation)
-    // that also relies on that utility. When it comes to the key for the cache,
-    // we use the Cantor pairing function with the address of the two variables
-    // as parameters, thus ensuring the uniqueness of the key (see
-    // https://en.wikipedia.org/wiki/Pairing_function#Cantor_pairing_function).
+    // that also relies on that utility.
 
     auto v1 = reinterpret_cast<uintptr_t>(variable1.get());
     auto v2 = reinterpret_cast<uintptr_t>(variable2.get());
 
-    if (v2 < v1) {
-        v1 += v2;
-        v2 = v1 - v2;
-        v1 = v1 - v2;
+    if (v1 > v2) {
+        std::swap(v1, v2);
     }
 
-    auto key = ((v1 + v2) * (v1 + v2 + 1) >> 1U) + v2;
-    auto cacheKey = mPimpl->mCachedEquivalentVariables.find(key);
+    auto key = AnalyserModel::AnalyserModelImpl::VariableKeyPair {v1, v2};
+    auto it = mPimpl->mCachedEquivalentVariables.find(key);
 
-    if (cacheKey != mPimpl->mCachedEquivalentVariables.end()) {
-        return cacheKey->second;
+    if (it != mPimpl->mCachedEquivalentVariables.end()) {
+        return it->second;
     }
 
     auto res = libcellml::areEquivalentVariables(variable1, variable2);

src/analysermodel_p.h

@@ -16,7 +16,8 @@ limitations under the License.
 
 #pragma once
 
-#include <map>
+#include <cstdint>
+#include <unordered_map>
 
 #include "libcellml/analysermodel.h"
 
@@ -45,6 +46,33 @@ struct AnalyserModel::AnalyserModelImpl
 
     std::vector<AnalyserEquationPtr> mAnalyserEquations;
 
+    struct VariableKeyPair
+    {
+        uintptr_t first;
+        uintptr_t second;
+
+        bool operator==(const VariableKeyPair &other) const
+        {
+            return (first == other.first) & (second == other.second);
+        }
+    };
+
+    struct VariableKeyPairHash
+    {
+        size_t operator()(const VariableKeyPair &pair) const
+        {
+            // A simple and portable hash function for a pair of pointers.
+
+            size_t hash = pair.first;
+
+            hash ^= pair.second + 0x9e3779b9 + (hash << 6) + (hash >> 2);
+
+            return hash;
+        }
+    };
+
+    std::unordered_map<VariableKeyPair, bool, VariableKeyPairHash> mCachedEquivalentVariables;
+
     bool mNeedEqFunction = false;
     bool mNeedNeqFunction = false;
     bool mNeedLtFunction = false;
@@ -72,8 +100,6 @@ struct AnalyserModel::AnalyserModelImpl
     bool mNeedAcschFunction = false;
     bool mNeedAcothFunction = false;
 
-    std::map<uintptr_t, bool> mCachedEquivalentVariables;
-
     static AnalyserModelPtr create(const ModelPtr &model = nullptr);
 
     AnalyserModelImpl(const ModelPtr &model);

src/generator.cpp

@@ -1945,7 +1945,7 @@ std::string Generator::GeneratorImpl::generateInitialiseVariableCode(const Analy
             || (generatedConstantDependencies != nullptr)) {
             auto initialisingAnalyserVariable = std::find_if(remainingVariables.begin(), remainingVariables.end(),
                                                              [&](const AnalyserVariablePtr &av) {
-                                                                 return areEquivalentVariables(initialValueVariable, av->variable());
+                                                                 return mAnalyserModel->areEquivalentVariables(initialValueVariable, av->variable());
                                                              });
 
             if (initialisingAnalyserVariable != remainingVariables.end()) {

tests/bindings/javascript/generator.test.js

@@ -83,4 +83,91 @@ describe("Generator tests", () => {
         const equation_line_2 = libcellml.Generator.equationCodeByProfile(a.analyserModel().analyserEquation(0).ast(), gp)
         expect(equation_line_2.length).toBe(14)
     })
+    /*
+    test('Very big model multiple times', () => {
+        const fs = require('fs')
+        const path = require('path')
+
+        const issueFingerprint = (logger) => {
+            let fingerprint = ''
+            let issueCount = 0
+
+            const count = logger.issueCount()
+            for (let i = 0; i < count; ++i) {
+                const issue = logger.issue(i)
+
+                ++issueCount
+
+                fingerprint += `${issue.level()}|`
+                fingerprint += `${issue.referenceRule()}|`
+                fingerprint += `${issue.item().type()}|`
+                fingerprint += `${issue.url()}|`
+                fingerprint += `${issue.description()}\n`
+            }
+
+            return `issues=${issueCount}\n${fingerprint}`
+        }
+
+        const veryBigModel = fs.readFileSync(path.resolve(__dirname, "../../../../tests/resources/very_big_model.cellml"), "utf8")
+
+        const parser = new libcellml.Parser(false)
+        const printer = new libcellml.Printer()
+        const analyser = new libcellml.Analyser()
+        const generator = new libcellml.Generator()
+
+        let baselineParserFingerprint = ''
+        let baselinePrintedModel = ''
+        let baselineAnalyserFingerprint = ''
+        let baselineAnalyserModelType = libcellml.AnalyserModel.Type.UNKNOWN
+        let baselineInterfaceCode = ''
+        let baselineImplementationCode = ''
+
+        for (let i = 0; i < 10; ++i) {
+            const model = parser.parseModel(veryBigModel)
+
+            expect(model).not.toBeNull()
+
+            const parserFingerprint = issueFingerprint(parser)
+            const printedModel = printer.printModel(model)
+
+            analyser.analyseModel(model)
+
+            const analyserFingerprint = issueFingerprint(analyser)
+            const analyserModel = analyser.analyserModel()
+
+            expect(analyserModel).not.toBeNull()
+
+            const interfaceCode = generator.interfaceCode(analyserModel)
+            const implementationCode = generator.implementationCode(analyserModel)
+
+            if (i === 0) {
+                baselineParserFingerprint = parserFingerprint
+                baselinePrintedModel = printedModel
+                baselineAnalyserFingerprint = analyserFingerprint
+                baselineAnalyserModelType = analyserModel.type()
+                baselineInterfaceCode = interfaceCode
+                baselineImplementationCode = implementationCode
+            } else {
+                expect(parserFingerprint).toBe(baselineParserFingerprint)
+                expect(printedModel).toBe(baselinePrintedModel)
+                expect(analyserFingerprint).toBe(baselineAnalyserFingerprint)
+                expect(analyserModel.type()).toBe(baselineAnalyserModelType)
+                expect(interfaceCode).toBe(baselineInterfaceCode)
+                expect(implementationCode).toBe(baselineImplementationCode)
+            }
+
+            // Clean up the model and analyser model before the next iteration. Indeed, if we don't do this, then we end
+            // up with 10 models and 10 analyser models in memory at the same time, which causes the test to run out of
+            // memory.
+
+            analyserModel.delete()
+            model.delete()
+        }
+
+        generator.delete()
+        analyser.delete()
+        printer.delete()
+        parser.delete()
+    })
+    */
 })

tests/bindings/python/test_generator.py

@@ -52,6 +52,80 @@ def test_algebraic_eqn_computed_var_on_rhs(self):
         self.assertEqual("x = a", Generator.equationCode(am.analyserEquation(0).ast()))
         self.assertEqual("x = a", Generator_equationCode(am.analyserEquation(0).ast()))
 
+    """
+    def test_very_big_model_multiple_times(self):
+        from libcellml import Analyser
+        from libcellml import AnalyserModel
+        from libcellml import Generator
+        from libcellml import Parser
+        from libcellml import Printer
+        from test_resources import file_contents
+
+        def issue_fingerprint(logger):
+            fingerprint = ''
+            issue_count = 0
+
+            for i in range(logger.issueCount()):
+                issue = logger.issue(i)
+
+                issue_count += 1
+
+                fingerprint += f"{issue.level()}|"
+                fingerprint += f"{issue.referenceRule()}|"
+                fingerprint += f"{issue.item().type()}|"
+                fingerprint += f"{issue.url()}|"
+                fingerprint += f"{issue.description()}\n"
+
+            return f"issues={issue_count}\n{fingerprint}"
+
+        very_big_model = file_contents('very_big_model.cellml')
+
+        parser = Parser(False)
+        printer = Printer()
+        analyser = Analyser()
+        generator = Generator()
+
+        baseline_parser_fingerprint = ''
+        baseline_printed_model = ''
+        baseline_analyser_fingerprint = ''
+        baseline_analyser_model_type = AnalyserModel.Type.UNKNOWN
+        baseline_interface_code = ''
+        baseline_implementation_code = ''
+
+        for i in range(10):
+            model = parser.parseModel(very_big_model)
+
+            self.assertIsNotNone(model)
+
+            parser_fingerprint = issue_fingerprint(parser)
+            printed_model = printer.printModel(model)
+
+            analyser.analyseModel(model)
+
+            analyser_fingerprint = issue_fingerprint(analyser)
+            analyser_model = analyser.analyserModel()
+
+            self.assertIsNotNone(analyser_model)
+
+            interface_code = generator.interfaceCode(analyser_model)
+            implementation_code = generator.implementationCode(analyser_model)
+
+            if i == 0:
+                baseline_parser_fingerprint = parser_fingerprint
+                baseline_printed_model = printed_model
+                baseline_analyser_fingerprint = analyser_fingerprint
+                baseline_analyser_model_type = analyser_model.type()
+                baseline_interface_code = interface_code
+                baseline_implementation_code = implementation_code
+            else:
+                self.assertEqual(baseline_parser_fingerprint, parser_fingerprint)
+                self.assertEqual(baseline_printed_model, printed_model)
+                self.assertEqual(baseline_analyser_fingerprint, analyser_fingerprint)
+                self.assertEqual(baseline_analyser_model_type, analyser_model.type())
+                self.assertEqual(baseline_interface_code, interface_code)
+                self.assertEqual(baseline_implementation_code, implementation_code)
+    """
+
 
 if __name__ == '__main__':
     unittest.main()

tests/generator/generator.cpp

@@ -1754,3 +1754,76 @@ TEST(Generator, generateCodeUsingProfileEnum)
 
     EXPECT_EQ_FILE_CONTENTS("generator/algebraic_eqn_computed_var_on_rhs/model.py", generator->implementationCode(analyserModel, libcellml::GeneratorProfile::Profile::PYTHON));
 }
+
+/*
+TEST(Generator, veryBigModelMultipleTimes)
+{
+    auto issueFingerprint = [](const libcellml::LoggerPtr &logger) {
+        std::string fingerprint;
+        size_t issueCount = 0;
+
+        for (size_t i = 0; i < logger->issueCount(); ++i) {
+            const auto issue = logger->issue(i);
+
+            ++issueCount;
+
+            fingerprint += std::to_string(static_cast<int>(issue->level())) + "|";
+            fingerprint += std::to_string(static_cast<int>(issue->referenceRule())) + "|";
+            fingerprint += std::to_string(static_cast<int>(issue->item()->type())) + "|";
+            fingerprint += issue->url() + "|";
+            fingerprint += issue->description() + "\n";
+        }
+
+        return "issues=" + std::to_string(issueCount) + "\n" + fingerprint;
+    };
+
+    auto veryBigModel = fileContents("very_big_model.cellml");
+
+    auto parser = libcellml::Parser::create(false);
+    auto printer = libcellml::Printer::create();
+    auto analyser = libcellml::Analyser::create();
+    auto generator = libcellml::Generator::create();
+
+    std::string baselineParserFingerprint;
+    std::string baselinePrintedModel;
+    std::string baselineAnalyserFingerprint;
+    auto baselineAnalyserModelType = libcellml::AnalyserModel::Type::UNKNOWN;
+    std::string baselineInterfaceCode;
+    std::string baselineImplementationCode;
+
+    for (size_t i = 0; i < 10; ++i) {
+        auto model = parser->parseModel(veryBigModel);
+
+        ASSERT_NE(nullptr, model);
+
+        const auto parserFingerprint = issueFingerprint(parser);
+        const auto printedModel = printer->printModel(model);
+
+        analyser->analyseModel(model);
+
+        const auto analyserFingerprint = issueFingerprint(analyser);
+        const auto analyserModel = analyser->analyserModel();
+
+        ASSERT_NE(nullptr, analyserModel);
+
+        const auto interfaceCode = generator->interfaceCode(analyserModel);
+        const auto implementationCode = generator->implementationCode(analyserModel);
+
+        if (i == 0) {
+            baselineParserFingerprint = parserFingerprint;
+            baselinePrintedModel = printedModel;
+            baselineAnalyserFingerprint = analyserFingerprint;
+            baselineAnalyserModelType = analyserModel->type();
+            baselineInterfaceCode = interfaceCode;
+            baselineImplementationCode = implementationCode;
+        } else {
+            EXPECT_EQ(baselineParserFingerprint, parserFingerprint);
+            EXPECT_EQ(baselinePrintedModel, printedModel);
+            EXPECT_EQ(baselineAnalyserFingerprint, analyserFingerprint);
+            EXPECT_EQ(baselineAnalyserModelType, analyserModel->type());
+            EXPECT_EQ(baselineInterfaceCode, interfaceCode);
+            EXPECT_EQ(baselineImplementationCode, implementationCode);
+        }
+    }
+}
+*/