Benchmark PR 9 - #19
Conversation
The FallbackLocaleList object tells I18n::Backend::Fallbacks what order the languages should be attempted in. Because of the translate_accelerator patch, the SiteSetting.default_locale is *not* guaranteed to be fully loaded after the server starts, so a call to ensure_loaded! is added after the locale is set for the current user. The declarations of config.i18n.fallbacks = true in the environment files were actually garbage, because the I18n.default_locale was SiteSetting.default_locale, so there was nothing to fall back to. *derp*
celmis-codereviewer
left a comment
celmis-codereviewer
left a comment
There was a problem hiding this comment.
💬 COMMENT — findings to consider
Full findings and scope are in the review summary comment on this pull request — one persistent comment, updated in place on every run.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
celmis-codereviewer
left a comment
celmis-codereviewer
left a comment
There was a problem hiding this comment.
💬 COMMENT — findings to consider
Full findings and scope are in the review summary comment on this pull request — one persistent comment, updated in place on every run.
🤖 Code Review for PR #19⚠ PARTIAL REVIEW — defect did not run. defect is a critical stage, so this review cannot be an approval. defect: the model's reply could not be read as findings, twice. ⚙ ADJUSTED — graph context partial (3 of 7 changed files): 4 of 7 changed files have no symbols in the index; 2 of them are still in the checkout the index was built from (config/environments/production.rb, config/environments/profile.rb) — the index is stale there, or the extractor could not parse it; run 💬 COMMENT — findings to consider No issues detected. Scope
Performance
Powered by Code Analyzer · context: tree-sitter graph + structural, cve, security, contract |
2 participants
Benchmark reproduction of ai-code-review-evaluation#9