Benchmark: grafana PR 97529

[celmis-codereviewer]

Benchmark reproduction of grafana#97529

[celmis-codereviewer]

💬 COMMENT — findings to consider

Full findings and scope are in the review summary comment on this pull request — one persistent comment, updated in place on every run.

[celmis-codereviewer]

❌ CHANGES REQUESTED — blocking findings

Full findings and scope are in the review summary comment on this pull request — one persistent comment, updated in place on every run.

[celmis-codereviewer]

Why: ctx is not declared as a parameter or variable in NewResourceServer on line 255; calling s.Init(ctx) on line 258 results in a compile-time error undefined: ctx.

🔴 Undeclared variable ctx passed to s.Init

NewResourceServer accepts opts ResourceServerOptions as its parameter and does not declare or receive a ctx context.Context variable. Invoking s.Init(ctx) on line 258 fails compilation with undefined: ctx.

Suggested change

	err := s.Init(ctx)
	err := s.Init(context.Background())

_{agent: defect · rule: defect.undefined-variable · confidence: 0.95}

[celmis-codereviewer]

Why: When concurrent calls to BuildIndex occur for the same key after removing the b.cacheMu lock, both calls execute bleve.New on line 98 using the same directory path, leading to concurrent file access errors or index corruption.

🟠 Unsynchronized file-backed Bleve index creation leads to race conditions

Removing b.cacheMu.Lock() from the beginning of BuildIndex allows concurrent operations for the same resource key to execute bleve.New(dir, mapper) simultaneously on the same filesystem directory path (dir). Creating or opening a Bleve index concurrently on identical directory paths causes file locking conflicts and database corruption.

_{agent: defect · rule: defect.race-condition · confidence: 0.90}

[celmis-codereviewer]

🤖 Code Review for PR #20

❌ CHANGES REQUESTED — blocking findings

Findings

• 🔴 Critical: 1
• 🟠 Error: 1

Scope

• Files changed: 5
• Lines: +25 / -57

Performance

• Analysis time: 73.2s · agents: structural, cve, contract, security, defect · tokens: 25,543/15,852

---

_{Powered by Code Analyzer · context: tree-sitter graph + structural, cve, contract, security, defect}