Benchmark: sentry PR 80528 - #10
Conversation
Since we'll be doing more with issue occurrences split out the concept of incidents into it's own logic module, as well as incident_occurrence into it's own module
celmis-codereviewer
left a comment
There was a problem hiding this comment.
💬 COMMENT — findings to consider
Full findings and scope are in the review summary comment on this pull request — one persistent comment, updated in place on every run.
| return { | ||
| "id": str(monitor_environment.monitor.guid), | ||
| "slug": str(monitor_environment.monitor.slug), | ||
| "name": monitor_environment.monitor.name, |
There was a problem hiding this comment.
Why: config is copied from monitor_environment.monitor.config on line 159 and updated on line 161, but line 167 passes monitor_environment.monitor.config instead of config into the returned dictionary.
🟠 Unused config dictionary copy returns original property in context payload
In get_monitor_environment_context, a shallow copy of monitor_environment.monitor.config is created as config and updated with human-readable schedule_type display text. However, line 167 returns the original monitor_environment.monitor.config dictionary instead of config, so the schedule_type display update is discarded when building the monitor context.
| "name": monitor_environment.monitor.name, | |
| "config": config, |
agent: defect · rule: defect.copy-paste · confidence: 0.95
🤖 Code Review for PR #10💬 COMMENT — findings to consider Findings
Scope
Performance
Powered by Code Analyzer · context: tree-sitter graph + cve, structural, contract, security, defect |
Benchmark reproduction of getsentry#80528