Skip to content

ENT-11784: dnf package module - #3069

Merged
nickanderson merged 1 commit into
cfengine:masterfrom
nickanderson:ENT-11784/master
Feb 5, 2026
Merged

nickanderson merged 1 commit into
cfengine:masterfrom
nickanderson:ENT-11784/master

Conversation

@nickanderson

@nickanderson nickanderson commented Nov 11, 2025 •

Copy link
Copy Markdown
Member
  • Uses dnf python library for interfacing with dnf to install and remove packages
  • Use rpm library for listing currently installed packages (it's seconds faster)

Ticket: ENT-11784

@nickanderson
nickanderson marked this pull request as draft November 12, 2025 19:45
@nickanderson nickanderson changed the title WIP: dnf package module ENT-11784: dnf package module Nov 12, 2025
@cf-bottom

Copy link
Copy Markdown

Thank you for submitting a pull request! Maybe @craigcomstock can review this?

@nickanderson
nickanderson marked this pull request as ready for review November 13, 2025 16:33
@nickanderson
nickanderson marked this pull request as draft November 13, 2025 16:34
@nickanderson

Copy link
Copy Markdown
Member Author

OOps, this one isnt' ready for review yet.

@nickanderson
nickanderson force-pushed the ENT-11784/master branch 3 times, most recently from e06d2b8 to a9eb479 Compare February 3, 2026 15:27
@nickanderson
nickanderson marked this pull request as ready for review February 3, 2026 15:32
@nickanderson
nickanderson requested review from larsewi and removed request for larsewi February 3, 2026 15:50
@nickanderson
nickanderson requested a review from larsewi February 3, 2026 16:43

@larsewi larsewi left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix pyright issues and also format with black. Then I will continue review afterwards

Comment thread modules/packages/vendored/dnf.mustache Resolved
Comment thread modules/packages/vendored/dnf.mustache Outdated
base.conf.assumeyes = DEFAULT_ASSUME_YES
if with_repos:
base.read_all_repos()
base.fill_sack(load_system_repo='auto')

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to pyright, the load_system_repo argument expects a boolean value, not string.

Comment thread modules/packages/vendored/dnf.mustache Resolved
Comment thread modules/packages/vendored/dnf.mustache Resolved
@nickanderson
nickanderson requested a review from larsewi February 4, 2026 11:12
@nickanderson

Copy link
Copy Markdown
Member Author

OK @larsewi I think I am ready for another review and squash

@larsewi larsewi left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

- Uses dnf python library for interfacing with dnf
- Use rpm library for currently installed packages (it's faster than dnf and /bin/rpm)

Ticket: ENT-11784
Changelog: Added dnf package module
@nickanderson
nickanderson merged commit 7f4b589 into cfengine:master Feb 5, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants