Repository navigation
fix(i2c): generate STOP after NACK and wait before next START - #225
Merged
Merged
Conversation
After AF/NACK the master stayed in MSL with SCL held low until something else wrote STOP (#222). Also wait for a pending STOP to clear before the START RMW so a stale STOP bit cannot be written back (#221). Applies to both blocking and async paths, including OnDrop cancel. Verified on CH32H417: NACK leaves the bus idle; i2c_scan and bme280_blocking still work. Co-Authored-By: Claude Code <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
blocking_writeto an absent address returnsErr(Nack)and leavesMSL=0 BUSY=0 SCL=1 SDA=1.cargo xtask run --example i2c_scanfinds BME280 @ 0x76 across repeated full-bus scans.cargo xtask run --example bme280_blockinginit + continuous measurements succeed.examples/ch32v307cargo check(embassy-enabled) succeeds.🤖 Generated with Claude Code