pipelines: contains-files: quote individual arguments to find #255
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of quoting externally the subshell call "$()", quote each find argument
individually. This is because in certain scenarios, the shell executing find may
expand some of the arguments if not quoted.
Previous to this patch, this pipeline instance:
```
- uses: test/tw/contains-files
with:
dir: "/etc/audit/rules.d/"
name: "*.rules"
type: "f"
```
May see the the * symbol interpreted by the shell, rather than by find, expanding
into whatever is in the filesystem, and therefore breaking the find call, like this:
```
find /etc/audit/rules.d/ -name some.rules someother.rules -type f
```
With this patch, the same pipeline instance would execute the right find call:
```
find /etc/audit/rules.d/ -name '*.rules' -type f
```
Signed-off-by: Arturo Borrero Gonzalez <[email protected]>
sergiodj
approved these changes
Dec 4, 2025
Contributor
sergiodj
left a comment
sergiodj
left a comment
There was a problem hiding this comment.
Yep! This is actually the correct way to do quoting when using $() :).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of quoting externally the subshell call "$()", quote each find argument individually. This is because in certain scenarios, the shell executing find may expand some of the arguments if not quoted.
Previous to this patch, this pipeline instance:
May see the the * symbol interpreted by the shell, rather than by find, expanding into whatever is in the filesystem, and therefore breaking the find call, like this:
With this patch, the same pipeline instance would execute the right find call: