fix(manifest): register brainpy-state and brainx-general-guard, relocate NEST branch - #7
Merged
chaoming0625 merged 3 commits intoJul 29, 2026
Conversation
The skills/brainpy-state/ and skills/brainx-general-guard/ directories were added without matching manifest.json entries, so the Agent Skills validation workflow failed on every run: its manifest check compares the sorted skills array against the sorted skill directories and rejects any difference. Add both entries to manifest.json, and add the matching paths to the package.json files list so the published tarball actually contains the directories that manifest.json declares. Both skills pass `skills-ref validate` unchanged.
AGENTS.md rule 1 permits only references/, scripts/, and agents/ beneath a skill, with references/ allowed one further grouping level. The NEST branch sat in a top-level NEST-compatible/ directory with its own nested references/ and scripts/, which no validator enforces but which no other skill follows. Relocate the whole branch to references/nest-compatible/, flattening its inner references/ into the grouping directory and keeping scripts/ alongside, which mirrors the existing references/brainstate-dynamics/ layout. Normalize the branch's routing links to skill-root-relative paths, matching SKILL.md and references/brainstate-dynamics/. This also removes a real hazard: nest-workflow.md routed to `references/model-library.md`, which after the move would resolve against the skill's own references/ directory rather than the NEST branch. Update the inbound links in SKILL.md and references/component-selection.md, and the layout tree, nested-branch table, and script paths in plan.md. No skill content changes; all six skills still pass `skills-ref validate`.
chaoming0625
deleted the
fix/register-brainpy-state-and-general-guard-skills
branch
July 29, 2026 06:47
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why CI was failing
Every recent run of
Agent Skills validationfailed at the Verify the skill manifest step:skills/brainpy-state/andskills/brainx-general-guard/were added without matchingmanifest.jsonentries. The workflow compares the sorted manifest array against the sorted directory listing and fails on any difference in either direction (AGENTS.md rule 6). The failure happened before the per-skill validation step ever ran, so no skill was actually being validated in CI.The same omission left both directories out of
package.jsonfiles(rule 7). CI does not check that, so it was a latent packaging bug:manifest.jsonwould have declared skills the published tarball did not contain, andinstallation/lib/bundle.jsrejects undeclared directories underskills/.Changes
1. Register the two skills —
manifest.jsonandpackage.jsonfiles. This is the CI fix.2. Relocate the NEST-compatible branch —
skills/brainpy-state/NEST-compatible/violated rule 1, which permits onlyreferences/,scripts/, andagents/beneath a skill. Moved toreferences/nest-compatible/, flattening its innerreferences/into the grouping directory and keepingscripts/alongside, mirroring the existingreferences/brainstate-dynamics/layout.Routing links in the branch are now skill-root-relative, matching
SKILL.mdandreferences/brainstate-dynamics/. This removes a real hazard:nest-workflow.mdrouted to`references/model-library.md`, which after the move would resolve against the skill's ownreferences/directory instead of the NEST branch. Inbound links inSKILL.mdandreferences/component-selection.md, plus the layout tree, nested-branch table, and script paths inplan.md, were updated to match.No skill prose or API content changed — the relocation is paths only.
Verification
All six skills validate:
Manifest check passes, and every skill now has only rule 1 subdirectories:
Every backticked
.md/.pyrouting target underskills/brainpy-state/was resolved against the filesystem; all now exist. The only unresolved names are upstream NEST example filenames quoted inside script docstrings, which are prose, not routing links.Pre-existing issue, not fixed here
references/brainstate-dynamics/brain-dynamics-event-driven-operators.mdhas a "## Used by" block listingreferences/brainstate-dynamics/dynamics-and-integration.mdandreferences/brainstate-dynamics/brain-dynamics-snn-workflows.md. Neither file exists in this skill; they look likeskills/brainstate/paths. Present inHEADbefore this branch and left untouched.