Skip to content

fix: stop matching GOAWAY by a deprecated type #415

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
taciturnaxolotl merged 1 commit into from
Oct 6, 2026
Merged

fix: stop matching GOAWAY by a deprecated type #415

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 7 additions & 8 deletions errors.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,7 +155,7 @@ var http2TransportErrorFragments = []string{
// detail on GOAWAY would misread as the "; CODE" of a stream error.
var http2ConnectionLostMessages = []string{
"http2: client connection lost", // health-check ping went unanswered
"http2: server sent GOAWAY and closed the connection", // stdlib's GoAwayError
"http2: server sent GOAWAY and closed the connection", // GoAwayError, from either http2 copy
}

// matchConnectionLost returns the entry of http2ConnectionLostMessages that
Expand All @@ -175,21 +175,20 @@ func matchConnectionLost(msg string) (string, bool) {
// errors, and GOAWAY frames, which originate from the transport rather
// than the application.
//
// x/net/http2 error types are matched by type. The standard library's copy
// lives in an internal package, so its equivalents are matched by message
// instead.
// Stream and connection errors are matched by type against x/net/http2.
// GOAWAY is matched by message instead: x/net deprecated GoAwayError
// without offering a replacement, and the standard library's copy of the
// package is internal, so neither one's type can be named here for long.
// Both spell the failure the same way, so one fragment covers them.
func IsTransportError(err error) bool {
if err == nil {
return false
}
var (
streamErr http2.StreamError
connErr http2.ConnectionError
goAwayErr http2.GoAwayError
)
if errors.As(err, &streamErr) ||
errors.As(err, &connErr) ||
errors.As(err, &goAwayErr) {
if errors.As(err, &streamErr) || errors.As(err, &connErr) {
return true
}
// Wrapped errors embed the inner message, so scanning the top-level
Expand Down
Loading