Repository navigation
test: pin object streaming, content codecs, and openrouter reasoning formats - #421
Open
LarsArtmann wants to merge 1 commit into
Open
LarsArtmann wants to merge 1 commit into
LarsArtmann wants to merge 1 commit into
Conversation
7 of 8 tasks
…formats Characterization tests for the code the dedup PRs refactor next: object had no tests at all; the content codecs' provider metadata/options decode and openrouter's reasoning format labels were only pinned implicitly. Each test fails when the branch it covers is disabled.
LarsArtmann
force-pushed
the
characterization-tests
branch
from
October 24, 2026 10:12
fa798ab to
959c0c8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
objecthad no tests at all, and the content codecs' provider metadata/options decode and openrouter's reasoning format labels were only pinned implicitly. These tests pin that behavior before #420 refactors it, so the refactor lands with its safety net already onmain.object/object_test.godrives both streamers (StreamWithText,StreamWithTool) with a scripted model: partial deltas, parser-repaired truncation, the repair callback, duplicate-emission suppression, schema misses ending inNoObjectGeneratedError, finish-metadata forwarding, stream errors, and consumer-stop propagation (a counter proves the model stops being pulled).content_json_test.gopins the provider metadata and provider options decode through a test-registered provider type, including the no-data and empty-map paths and non-string text rejection.providers/openrouter/language_model_hooks_test.gopins theopenai-responses-v1/xai-responses-v1reasoning format labels following the model prefix.No production code changes: all three files pass on
mainas-is (a0f6ed1), and each test fails when the branch it covers is disabled (mutation-checked), so #420 is checked by these tests rather than merely accompanied by them.CONTRIBUTING.md.💘 Generated with Crush