Repository navigation
feat(retry): let an error decide for itself whether it is retryable - #438
Merged
Merged
Conversation
💘 Generated with Crush Assisted-by: Crush:claude-opus-5-5
andreynering
approved these changes
Oct 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Retry decisions are made by matching on what an error looks like: a
ProviderError, anet.Error, or a transport error. An error that knows it is worth retrying, but is none of those, has to dress up as one. Crush's request timeout was posing as anet.Errorjust to get retried, and even then a retryable timeout that wrapped a 400ProviderErrorlost to the provider error's own verdict.RetryableErrorinterface withIsRetryable() bool. The outermost one in the chain decides.ProviderErroralready has that method, so it satisfies the interface and its separate branch is gone.Used by charmbracelet/crush#3985, which has to point at a release containing this before it can merge.
💘 Generated with Crush