Skip to content

fix: When receiving MDN, mark all preceding messages as noticed, even having same timestamp (#7928) #8046

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
iequidoo merged 2 commits into from
Mar 29, 2026
Merged

fix: When receiving MDN, mark all preceding messages as noticed, even having same timestamp (#7928) #8046

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b0154b0
feat: Log received message sort timestamp
iequidoo Mar 26, 2026
cac9f3d
fix: When receiving MDN, mark all preceding messages as noticed, even…
iequidoo Mar 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions src/receive_imf.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1010,11 +1010,11 @@ UPDATE config SET value=? WHERE keyname='configured_addr' AND value!=?1
&& msg.chat_visibility == ChatVisibility::Archived;
updated_chats
.entry(msg.chat_id)
.and_modify(|ts| *ts = cmp::max(*ts, msg.timestamp_sort))
.or_insert(msg.timestamp_sort);
.and_modify(|pos| *pos = cmp::max(*pos, (msg.timestamp_sort, msg.id)))
.or_insert((msg.timestamp_sort, msg.id));
}
}
for (chat_id, timestamp_sort) in updated_chats {
for (chat_id, (timestamp_sort, msg_id)) in updated_chats {
context
.sql
.execute(
Expand All @@ -1023,12 +1023,13 @@ UPDATE msgs SET state=? WHERE
state=? AND
hidden=0 AND
chat_id=? AND
timestamp<?",
(timestamp,id)<(?,?)",
(
MessageState::InNoticed,
MessageState::InFresh,
chat_id,
timestamp_sort,
msg_id,
),
)
.await
Expand Down Expand Up @@ -2354,7 +2355,7 @@ RETURNING id

info!(
context,
"Message has {icnt} parts and is assigned to chat #{chat_id}."
"Message has {icnt} parts and is assigned to chat #{chat_id}, timestamp={sort_timestamp}."
);

if !chat_id.is_trash() && !hidden {
Expand Down
Loading