Conversation
This change might be controversal. According to the `test_forward_quote` test (introduced in 6b3b33d, #2843), this behavior is intentional. That MR only removed the message ID assignment but did _not_ remove the text altogether. On the other hand other messengers, including Telegram and WhatsApp, don't do this (they don't forward quotes together with messages). I argue that doing this is not expected by most users, and is bad for privacy. Forwarding a message should only forward that message, and not carry any more information. How I came to this: I was working on #8053 trying to undestand why the quoted message ID defaults to the last message of the target chat. And, thanks to 3f27be9, I questioned: "Why are we forwarding quotes in the first place?". So this also closes #8053. Note that this commit does not alter `quoted_message()`. That's for displaying old messages, and for compatibility with senders that do not remove the quote from forwarded messages.
|
Looks good, makes sense for me not to forward the quote if other messengers don't do this, but let's ask @r10s |
|
just yesterday got a message forwarded that would not be understandable without the context of the quote. i also do not see, that there is a privacy issue - by forwarding, the message itself is already not by them, the quote is forwarded the same way. also, the user can forward the quoted message additionally. so, looking at the issue without looking what others are doing, it seems fine as it is today, and also not unexpected. we also never got any complains in all the years. however, if really all other messengers do not forward the quote, this is a strong argument as well, and we should at least look at that closely. not sure why they do so, many messengers are more "social networks", so maybe to protect from that part (not so long ago, forwarded messages on whatsapp were not even marked as such, resulting in lots of confusion and pushback - maybe they went too far by fixing that. so, i am not against this PR, but i would also not rush (everyone is busy right now), but waiting for feedback |
My point is that you think that you forward one message, but actually you forward two basically. If "not by them" you mean that the author's account gets stripped then I don't think that it's enough. At the very least this argument wouldn't work if all your message history got leaked, but with no author names.
If one needs to provide context to a message then you simply forward multiple messages. |
3 participants
This change might be controversal.
According to the
test_forward_quotetest(introduced in 6b3b33d,
#2843),
this behavior is intentional.
That MR only removed the message ID assignment
but did not remove the text altogether.
On the other hand other messengers, including Telegram and WhatsApp,
don't do this (they don't forward quotes together with messages).
I argue that doing this is not expected by most users,
and is bad for privacy.
Forwarding a message should only forward that message,
and not carry any more information.
How I came to this: I was working on
#8053
trying to undestand why the quoted message ID defaults
to the last message of the target chat.
And, thanks to 3f27be9,
I questioned: "Why are we forwarding quotes in the first place?".
So this also closes #8053.
Note that this commit does not alter
quoted_message().That's for displaying old messages,
and for compatibility with senders that do not remove the quote
from forwarded messages.