Conversation
carlansley
requested changes
May 29, 2025
| assert.equal(result.totalReviewers, 3); | ||
| assert.equal(result.oldestApprovedReviewDate, '2023-10-01T01:03:30Z'); | ||
|
|
||
| // Ensure the oldest review is more than 90 days old |
Contributor
There was a problem hiding this comment.
I don't understand this test, or maybe I don't understand the code. But the implementation throws an error, shouldn't we be checking for that somehow?
Contributor
Author
There was a problem hiding this comment.
That's how the tests were originally put together which does seem odd, I can't recall the history here.
I've created another test file that exercises the larger action.
|
Coverage after merging cr-pr-reivews-timelimit into main will be
Coverage Report |
Contributor
Author
|
Ready for another look! |
carlansley
approved these changes
Jun 4, 2025
|
✅ PR review status - All reviews completed and approved! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #86