Fix error 126 by registering DLL search directory for Windows PowerSh… - #366
Merged
Conversation
…ell paths Backport of main commit f9c0fb4 (CHEF-37610, #364). Windows' default LoadLibrary(Ex) search order used by FFI does not include the directory of the DLL being loaded, so native VC++ runtime dependencies (vcruntime140.dll, msvcp140.dll, etc.) living alongside Chef.PowerShell.Wrapper.dll / Chef.PowerShell.Wrapper.Core.dll could fail to resolve with error 126 even though the wrapper DLL itself loaded fine via its absolute path. Adds a shared ChefPowerShell::Kernel32 FFI module (SetDefaultDllDirectories/ AddDllDirectory/SetDllDirectoryA) and registers the resolved bin directories before executing, for both the Windows PowerShell (.NET Framework 4.8.1) and pwsh (.NET Core) code paths. Adapted to this branch's existing resolve_wrapper_dll/resolve_core_wrapper_dll DLL resolution instead of main's ChefPowerShell.bin_dir helper, which does not exist on 18-Stable. Signed-off-by: John McCrae <mccrae@progress.com>
Signed-off-by: John McCrae <mccrae@progress.com>
tpowell-progress
approved these changes
Sep 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ell paths
Backport of main commit f9c0fb4 (CHEF-37610, #364).
Windows' default LoadLibrary(Ex) search order used by FFI does not include the directory of the DLL being loaded, so native VC++ runtime dependencies (vcruntime140.dll, msvcp140.dll, etc.) living alongside Chef.PowerShell.Wrapper.dll / Chef.PowerShell.Wrapper.Core.dll could fail to resolve with error 126 even though the wrapper DLL itself loaded fine via its absolute path.
Adds a shared ChefPowerShell::Kernel32 FFI module (SetDefaultDllDirectories/ AddDllDirectory/SetDllDirectoryA) and registers the resolved bin directories before executing, for both the Windows PowerShell (.NET Framework 4.8.1) and pwsh (.NET Core) code paths. Adapted to this branch's existing resolve_wrapper_dll/resolve_core_wrapper_dll DLL resolution instead of main's ChefPowerShell.bin_dir helper, which does not exist on 18-Stable.
Description
Related Issue
Types of changes
Checklist:
Gemfile.lockhas changed, I have used--conservativeto do it and included the full output in the Description above.