Point the build status badge at GitHub Actions - #1119
Open
tas50 wants to merge 1 commit into
Open
Conversation
The README's build badge still pointed at the chef-oss/chef-cookstyle-main-verify Buildkite pipeline. CI moved to GitHub Actions, so the badge reflected a pipeline that no longer gates this repo. Swap it for the unit workflow, filtered to main, which is the workflow that actually runs the test suite on every push to main. Verified the badge SVG and its target both return 200 and that the badge currently renders 'unit - passing'. Signed-off-by: Tim Smith <tsmith84@proton.me>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The README build badge still pointed at the
chef-oss/chef-cookstyle-main-verifyBuildkite pipeline. CI runs on GitHub Actions now, so the badge showed the status of a pipeline that no longer gates this repo.This swaps it for the
unitworkflow badge, filtered tomain— that is the workflow that actually runs the test suite on every push tomain. The link target uses?query=branch%3Amainso clicking through lands on the main-branch runs rather than all runs.Verification
unit - passing.bundle exec rake— 1239 examples, 0 failures; lint andvalidate_configpass.Left alone deliberately: there is also a
lintworkflow running onmainthat has no badge. Adding one is outside what this change is for, so flagging it rather than bundling it in.