Update my author email to tsmith84@proton.me - #1123
Open
tas50 wants to merge 1 commit into
Open
Conversation
The Author:: headers carried two older addresses, tsmith84@gmail.com on 398 files and tsmith@chef.io on 10. Both now point at tsmith84@proton.me, which is the address already used in cookstyle.gemspec. One change is not a header: the Chef/Security/SshPrivateKey spec used the old address as the trailing comment field of a fake SSH public key. It is test data rather than an attribution, but it is still the old address sitting in a public repo, so it goes too. The replacement is the same length and the block is an expect_no_offenses, so no caret alignment was affected. No other lines changed. Signed-off-by: Tim Smith <tsmith84@proton.me>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
My
Author::headers carried two older addresses. Both now point attsmith84@proton.me, which is already the address incookstyle.gemspec.tsmith84@gmail.comtsmith@chef.io408 files, 409 lines. Every changed line is one of three shapes, and nothing else in the tree was touched:
The one line that isn't a header
spec/rubocop/cop/chef/security/ssh_private_key_spec.rbused the old address as the trailing comment field of a fake SSH public key:That's test data rather than an attribution, but it's still the old address sitting in a public repo, so it goes too.
tsmith84@gmail.comandtsmith84@proton.meare both 18 characters and the block is anexpect_no_offenses, so no caret alignment was affected.Verification
rake validate_configpassesbundle exec cookstyleunchanged at the 11 pre-existing offenses