rcbridge: Replace CA certs at the crypto/x509 layer#290
Merged
Conversation
Hooking per-request via rclone's fshttp happens too late and ends up overriding the user's override.ca_cert configuration if set. Instead, systemRoots in golang's crypto/x509 now gets replaced directly. This eliminates the need to have a fork of rclone too. Fixes: #287 Signed-off-by: Andrew Gunnerson <accounts+github@chiller3.com>
chenxiaolong
added a commit
that referenced
this pull request
May 27, 2026
Signed-off-by: Andrew Gunnerson <accounts+github@chiller3.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hooking per-request via rclone's
fshttphappens too late and ends up overriding the user'soverride.ca_certconfiguration if set. Instead,systemRootsin golang'scrypto/x509now gets replaced directly. This eliminates the need to have a fork of rclone too.Fixes: #287